Closed taartspi closed 1 year ago
I created a pull request #236 It contains code changes for items 1 and 2. If you agree with this please move it thru the process as I know a user will want this when I provide the ADS1256 code.
Separately item 3. If you agree changes are needed describe which way you prefer and I will do that with another pull request.
thanks Tom
@eitch @FDelporte
item 3 fixed with PR 248
All items now resolved/integrated
I need mode1 on spi0. The SPI Provider prevents this. The spi provider comment states " // SPI MODE_1 and MODE_2 are not supported on the AUX SPI BUS_1 by PiGPIO" The code does not agree so a simple change let me create the spi.
A) should these two attributes be required B) use a != null check and only overwrite the flags if they were supplied. This would allow the user to set flags that may not function and create debug nightmare, so I think they being required is better but requires existing user to update code when moving this code level.