Pi4J / pi4j-v2

Pi4J Version 2.0
Apache License 2.0
266 stars 54 forks source link

GitHub Action should not run completely in a fork #270

Open FDelporte opened 1 year ago

FDelporte commented 1 year ago

As reported by @taartspi: I created a fork and the build fails in GitHub Actions.

Solution: adapt the build script to not run completely in forks.

taartspi commented 1 year ago

after updating my fork with changes on the parent repo the build process email: [taartspi/pi4j-v2] Run failed: Build develop snapshot and push to download repo - develop (83d72bc)

the expanded details ci-development-snapshot.yml on push

Build & Deploy Snapshot Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

thanks Tom

FDelporte commented 1 year ago

strange, just tried all builds on current develop branch, and this node message doesn't appear... @eitch any idea if/where node is used in actions?

taartspi commented 1 year ago

Not sure it matters in duplication. But my environment is as follows. My fork of v2 in github. I have it cloned on my pi. I develop on the pi and push to my fork then do a pull request.