Closed MMMMMNG closed 9 months ago
Hi MNG, thanks for your contribution! Our first Hacktoberfest ever. I love your humor regarding #300 and indeed a project without issues is a dead project so thanks for reporting and proposing a fix. Looks good at first quick sight, will dive in a bit deeper later and come back to this.
This PR is supposed to fix Issues #298, #299 and last but certainly not least Issue #300!
It is also supposed to be part of Hacktoberfest. According to the FAQ, if you add the
You could also open the entire repo to Hacktoberfest, could be worthwhile. Here's the relevant info.
hacktoberfest-accepted
label to my PR, it will count - that is, should you choose to accept it ofc. ;)I was made aware of these shortcomings of the MockSpi class by my working extensively with Roberts class for interfacing with the MCP23S17 Integrated Circuit.
Here's an example of how I use this revised version of MockSpi:
There are more working examples in my fork of Roberts project.
Feel free to give feedback and I will try to adapt the code as ASAP as possible. Also, if you accept the PR, please don't forget to label it
hacktoberfest-accepted
🙏.Cheers! -MNG