search

Pi4J / pi4j-v2

Pi4J Version 2.0
Apache License 2.0
273 stars 57 forks source link

fix unnecessary sting concatenation in logging statements; downgrade logging level to INFO in BAU places #370

Closed ylexus closed 2 months ago

ylexus commented 2 months ago

369

FDelporte commented 2 months ago

wow, thanks @ylexus, exactly the kind of review the logging needed! looks good af first sight, will dive in a bit deeper one of the next days

FDelporte commented 2 months ago

Thanks for the cleanup, but you changes some of the loggers from warning to info. Please undo that.

@eitch see ticket #369, some warnings at the start of the Pi4J context could, in my opinion, indeed be changed to info. Others we will need to review.

ylexus commented 2 months ago

Yes, those changes to INFO was the whole point of this, the rest is just a side effect (automatic refactoring). Apologies, I should have mentioned the original issue is in the PR title and not in the first comment.

eitch commented 2 months ago

You mixed two things in the same commit. Can you please change that, then i'll merge your request. Commits should clearly define what they change, which is not the case here

ylexus commented 2 months ago

@eitch done

ylexus commented 2 months ago

Thanks, how often do you do releases? Just to know when to expect this change to be released.

eitch commented 2 months ago

As often as needed. We just did a 2.6.1. We might do a 2.6.2 soon.