PiBrewing / craftbeerpi4

GNU General Public License v3.0
57 stars 29 forks source link

Ouput test branch to increase resolution of actor output #145

Open avollkopf opened 1 month ago

avollkopf commented 1 month ago

@brackendalebrewing, although, no new issue has been created, I am working on a feasibility version for your request on the actor output resolution.

There is one branch for the server and another for the UI

A variable self.output and self.outputmax has to be used in a new sensor if this feature is used. There is an example in the mqtt folder -> MQTT actor (output).

It has an action to set power or / and output and you can define the max output value.

-> I have not yet tested a logic, but a modified / new logic plugin needs to set the output instead of the power if you want to use this feature.

The UI is also modified -> As powerslider you can define power or output.

Please try and give feedback, if this is something you can work with.

Server UI

Alex

brackendalebrewing commented 1 month ago

Hi

Thank you for the update. I will review/try as soon as I can. Work/business is keeping me very busy at the moment.

Thanks Andy

On Sun, 11 Aug 2024 at 21:58, Alexander Vollkopf @.***> wrote:

@brackendalebrewing https://github.com/brackendalebrewing, although, no new issue has been created, I am working on a feasibility version for your request on the actor output resolution.

There is one branch for the server and another for the UI

A variable self.output and self.outputmax has to be used in a new sensor if this feature is used. There is an example in the mqtt folder -> MQTT actor (output).

It has an action to set power or / and output and you can define the max output value.

-> I have not yet tested a logic, but a modified / new logic plugin needs to set the output instead of the power if you want to use this feature.

The UI is also modified -> As powerslider you can define power or output.

Please try and give feedback, if this is something you can work with.

Server https://github.com/PiBrewing/craftbeerpi4/tree/outputtest UI https://github.com/PiBrewing/craftbeerpi4-ui/tree/outputtest

Alex

— Reply to this email directly, view it on GitHub https://github.com/PiBrewing/craftbeerpi4/issues/145, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJUAW6U6A4MHBI6DSE4O3ULZRA6HNAVCNFSM6AAAAABMLNL2P2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3DAMBUGE4DANY . You are receiving this because you were mentioned.Message ID: @.***>

brackendalebrewing commented 3 weeks ago

Subject: Re: Update on Actor Output Resolution Feature

Hi Alex,

Thanks for the update and for working on this feature. I think the modification you've made will work well for what I need. I'll update you as soon as I modify and test my plugins with this new setup.

I appreciate your efforts and will keep you posted on how it goes.

Best regards, Andy

On Mon, 12 Aug 2024 at 12:06, a Coop @.***> wrote:

Hi

Thank you for the update. I will review/try as soon as I can. Work/business is keeping me very busy at the moment.

Thanks Andy

On Sun, 11 Aug 2024 at 21:58, Alexander Vollkopf @.***> wrote:

@brackendalebrewing https://github.com/brackendalebrewing, although, no new issue has been created, I am working on a feasibility version for your request on the actor output resolution.

There is one branch for the server and another for the UI

A variable self.output and self.outputmax has to be used in a new sensor if this feature is used. There is an example in the mqtt folder -> MQTT actor (output).

It has an action to set power or / and output and you can define the max output value.

-> I have not yet tested a logic, but a modified / new logic plugin needs to set the output instead of the power if you want to use this feature.

The UI is also modified -> As powerslider you can define power or output.

Please try and give feedback, if this is something you can work with.

Server https://github.com/PiBrewing/craftbeerpi4/tree/outputtest UI https://github.com/PiBrewing/craftbeerpi4-ui/tree/outputtest

Alex

— Reply to this email directly, view it on GitHub https://github.com/PiBrewing/craftbeerpi4/issues/145, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJUAW6U6A4MHBI6DSE4O3ULZRA6HNAVCNFSM6AAAAABMLNL2P2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3DAMBUGE4DANY . You are receiving this because you were mentioned.Message ID: @.***>

avollkopf commented 3 weeks ago

Thanks for the reply. Witing for your feedback. I am sure, the code for server and UI needs a bit more finetuning, but this can be done, once you conform it is working for your application.