PiBrewing / craftbeerpi4

GNU General Public License v3.0
57 stars 29 forks source link

image-url for docker creation needs to be lowercase -> to be adapted #95

Closed avollkopf closed 1 year ago

avollkopf commented 1 year ago

@papauorg Same issues have been described here: https://github.com/orgs/community/discussions/25768

Maybe you can find a solution faster than i would :-)

avollkopf commented 1 year ago

@papauorg , @dereulenspiegel

Although, the image seems to be build correctly, it cannot be pushed:

ERROR: failed to solve: failed to push ghcr.io/pibrewing/craftbeerpi4:dev: unexpected status: 403 Forbidden
Error: buildx failed with: ERROR: failed to solve: failed to push ghcr.io/pibrewing/craftbeerpi4:dev: unexpected status: 403 Forbidden

Adding write permissions in the build.yml did not help.

Not sure, if settings in the org need to be changed: image

Currently, I have no rights to change that setting

papauorg commented 1 year ago

@avollkopf Yes, I think that's it. It should look like this: image

Not sure if it has something to do with the casing, too. We'll see when the permissions are set ... :)

Edit:

Not sure, if settings in the org need to be changed:

I not sure how this is done in an org, but the permissions can usually be set on repository level

avollkopf commented 1 year ago

Edit:

Not sure, if settings in the org need to be changed:

I not sure how this is done in an org, but the permissions can usually be set on repository level

Right, I was also referring to the repo and not the entire org. But here I can't change the setting to 'Read and Write'

papauorg commented 1 year ago

Hm, strange. I would expect the owner of the org to be allowed to change the repos settings. But otherwise we could try setting the permissions in the workflow file directy: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

avollkopf commented 1 year ago

Could change only the orgs global settings. Now repo settings have been changed and are flexible. Flow went through