search

PiInTheSky / lora-gateway

LoRa gateway to Habitat
96 stars 69 forks source link

Stop overwriting of SSDV files #46

Open hyde00001 opened 6 years ago

hyde00001 commented 6 years ago

In V1.8.19 and possibly earlier, if the SSDV image count wraps from 255 (the maximum SSDV utilises) back to 0, the LoRa Gateway ssdv folder over-writes older images with newer images with the same index count. Could code be added to avoid this, and retain all received images? Perhaps this could be achieved by creating subfolders for each cycle through the SSDV image count on a given day or by prefixing/suffixing the image file name with date and/or time. Obviously, other approaches exist to resolve this behaviour.

Thanks for all the effort maintaining this excellent application.

Steve Hyde - hyde00001

KevWal commented 3 years ago

I have also found this issue with my flight yesterday, and on a related point the wrap at 255 causes ssdv_resend.py to not work beyond image 255 too. I did have a look through the code but couldn't find anything obvious that was causing the wrap.

Thanks very much Kevin

daveake commented 3 years ago

The wrapping is because SSDV uses a single byte for the image number; PITS and the gateway need to do the same.

On Sun, 28 Feb 2021, 19:16 Kevin Walton, notifications@github.com wrote:

I have also found this issue with my flight yesterday, and on a related point the wrap at 255 causes ssdv_resend.py to not work beyond image 255 too. I did have a look through the code but couldn't find anything obvious that was causing the wrap.

Thanks very much Kevin

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PiInTheSky/lora-gateway/issues/46#issuecomment-787506320, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIGQ5HZ4PVL2S7WCV2HSATTBKJCFANCNFSM4E4C6NUA .