search

PiInTheSky / lora-gateway

LoRa gateway to Habitat
96 stars 69 forks source link

MaxAFCStep may be used uninitialised #56

Closed ED6E0F17 closed 6 years ago

ED6E0F17 commented 6 years ago

I may be missing something, but If I don`t set MaxAFCstep in config, I am not going to be able to use calling mode to correct drifty payloads.

PiInTheSky commented 6 years ago

If you don't set a value, it will be zero, which disables its action. So AFC works but isn't bounded.

ED6E0F17 commented 6 years ago

Thanks, I should have been paying more attention to the code. You could set a sensible default value, but it is not a problem.

daveake commented 6 years ago

Yeah, that's reasonable. I'll add to the list.

Dave

On 10 July 2018 at 22:24, ED6E0F17 notifications@github.com wrote:

Thanks, I should have been paying more attention to the code. You could set a sensible default value, but it is not a problem.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PiInTheSky/lora-gateway/issues/56#issuecomment-403970788, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBodJGmznnDvKvXNcvYuKmvdAXVDIZ8ks5uFRuLgaJpZM4VJpHp .

ED6E0F17 commented 6 years ago

My actual problem was a typo in gateway.txt: "AFC0=Y", so if you could make AFC default to on, that would be good too.......

dbrooke commented 6 years ago

AFC is only needed at the narrower bandwidth settings so it doesn't necessarily make sense to default to on.

Also you can easily toggle the setting using the f or F key.