PITS does not listen for resend uplink when GPS -> Sats not > 0

[KevWal]

With the potential GPS issues caused by the Pi I have been doing some testing of that scenario, and one thing that breaks is SSDV Resend Uplink - because the code checks for GPS -> Sats > 0.

I have tested replacing this with simply GPS -> SecondsInDay > 0, to make sure it has a time, so it knows when to listen, but does not need an active GPS signal.

I was thinking about doing a Pull request to make that change - is that something you would support?

Thanks very much, Kevin

[PiInTheSky]

Well, the reason for that is that it needs an accurate clock, and the tracker will only have an accurate clock if it's had a valid GPS time. It could just test whether it's had valid GPS time at some point rather than currently having one.

But, just fix the GPS :)

On Sat, 27 Feb 2021 at 21:20, Kevin Walton notifications@github.com wrote:

With the potential GPS issues caused by the Pi I have been doing some testing of that scenario, and one thing that breaks is SSDV Resend Uplink - because the code checks for GPS -> Sats > 0.

I have tested replacing this with simply GPS -> SecondsInDay > 0, to make sure it has a time, so it knows when to listen, but does not need an active GPS signal.

I was thinking about doing a Pull request to make that change - is that something you would support?

Thanks very much, Kevin

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PiInTheSky/pits/issues/40, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4ERK4TZ6ZK7VYOV3NZSF3TBFOZBANCNFSM4YKKHAJQ .

[KevWal]

Id love to just fix the GPS - but that means a £20 active aerial, which double the cost of the payload compared to my current 1/4 whip - which to be fair has actually done fine on this flight. :)

Given how accurately the GPS clock maintains time once it has the time, I have tested:

• // KW What if we loose GPS in flight? We still keep time.
• // printf("KW GPS->SecondsInDay %ld\n", GPS->SecondsInDay);
• // if (GPS->Satellites > 0)
• if (GPS->SecondsInDay > 0)

in TDMTimeToSendOnThisChannel and UplinkTimeToSendOnThisChannel.

Just my 2p, up to you obviously :)

Cheers Kev

[daveake]

Yeah it's a simple change, so I'll do it.

On Sat, 27 Feb 2021, 22:41 Kevin Walton, notifications@github.com wrote:

Id love to just fix the GPS - but that means a £20 active aerial, which double the cost of the payload compared to my current 1/4 whip - which to be fair has actually done fine on this flight. :)

Given how accurately the GPS clock maintains time once it has the time, I have tested:

-

 // KW What if we loose GPS in flight?  We still keep time.

-

 // printf("KW GPS->SecondsInDay %ld\n", GPS->SecondsInDay);

-

 // if (GPS->Satellites > 0)

-

 if (GPS->SecondsInDay > 0)

in TDMTimeToSendOnThisChannel and UplinkTimeToSendOnThisChannel.

Just my 2p, up to you obviously :)

Cheers Kev

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PiInTheSky/pits/issues/40#issuecomment-787198884, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIGQ5HM7KMY2EEUZKPSFRDTBFYI7ANCNFSM4YKKHAJQ .

[daveake]

Done in version being issued this week.