search

PiLLLaa / pod

pod file
1 stars 1 forks source link

freezes path of diablo #1

Open wampirr opened 2 years ago

wampirr commented 2 years ago

freezes path of diablo some times using this one https://raw.githubusercontent.com/PiLLLaa/pod/master/S11FE_ENG_R_NEWSYMBOL(HC).filter i mean freeze + crush combo mostly on maps with much loot

wampirr commented 2 years ago

problem in your code must be in duplication(or even more mult) of logics in every second line. i know the specifics here, it s not about cpp and performance, but thats blocking entire game...need to optimize a bit

also this one: The higher the rule in your filter file, the higher priority it will have. This means if on the first line of your item filter you choose to hide all Spears but then on Line 2 you choose to show Spears with 6 sockets then the result is no spear will ever show.

you ll have to check some rare(low level for example) cases in the beginning and don t repeat all checks till the end

wampirr commented 2 years ago

mian problem example: you check gold to hide, but never check gold to show - so you go all filter till the end to show gold...

PiLLLaa commented 2 years ago

freezes path of diablo some times using this one https://raw.githubusercontent.com/PiLLLaa/pod/master/S11FE_ENG_R_NEWSYMBOL(HC).filter i mean freeze + crush combo mostly on maps with much loot

Ok, I'll check it as soon as possible with your all comments about filter. thanks for your feedback tome.

wampirr commented 2 years ago

i fixed just the most common items in the top of the filter and freezing is gone. https://github.com/wampirr/pod_item_filter thank you and sry for no pull req.

PiLLLaa commented 2 years ago

it s not about cpp and performance, but thats blocking entire game...need to optimize a bit

also this one: The higher the rule in your filter file, the higher priority it will have. This means if on the first line of your item filter you choose to hide all Spears but then on Line 2 you choose to show Spears with 6 sockets then the result is no spear will ever show.

you ll have to check some rare(low level for example) cases in the beginning and don t repeat all checks till the end

Is it directly affected by gold showing only? as you filter, you did touch the miscellaneous also.

wampirr commented 2 years ago

not 100% sure, i just "fixed"(at least tried as far as i understand it) the most uneffective. most common - must be in top, so most checks end fast(gold, misc, magics trash must be in top). and to make it actually end - use more direct HIDE(and try to do it in the top again), so checking stops at it.

wampirr commented 2 years ago

hmm, got a rare freezing crash again. i am 99% sure the reason is filter(random maps, random situations, much loot. and prev fix made it safer). im going to fix out all low lvl and further optimize. really like you style though =) keeping it

wampirr commented 2 years ago

hello again! heh, i have to admit 2 things; 1) without filter or with my minimalized filter crushing is much more rare 2) still happens (the filter is really min in that case, so problem is not only in the filter or not only in the filter complexity...)

thats all for me about the issue, sry if i was not right, thank you again and gl!

PiLLLaa commented 2 years ago
  1. i Thanks for your support!. Anyway, it looks like clearly to found out the problem about freezing.. Let's test it during next season starting. Maybe, it's best time to test filter. Have a nice day!