search

PiMaker / MonikAI

Monika from DDLC keeping you company on your desktop!
MIT License
92 stars 38 forks source link

Fixed updater not downloading the latest character response files #20

Closed zchaudhry11 closed 6 years ago

zchaudhry11 commented 6 years ago

The updater now performs a basic check to see if the currently downloaded response files are valid, otherwise it resets the update state so that the files are downloaded again.

PiMaker commented 6 years ago

Alright, the general fix seems fine, but I don't quite agree with your implementation of the ValidResponseData method. I don't think we wait until we go for multi-character, the values of the CSV filenames simply shouldn't be hardcoded, especially because we already know which files should be present using the update.json. If you implement that I'll merge it right away, if not I can also add it myself if you want.

PiMaker commented 6 years ago

Alright, I will merge it for now because I decided I want to push another release, but I think we should still move away from hardcoded CSV files pretty soon.