search

PiMaker / ltcgi

Optimized plug-and-play realtime area lighting using the linearly transformed cosine algorithm for Unity/VRChat.
https://ltcgi.dev
Other
442 stars 25 forks source link

Re-add using directive to fix udonless build #15

Closed shiyouganai closed 1 year ago

shiyouganai commented 1 year ago

This commit adds the use of the UnityEditor.Build.Reporting namespace back to the editor script that conditionally needs it (if UDONSHARP is not defined).

Out of the box v1.0.2 did not build in my VRChat-less Unity project; everything seems to work fine when I fixed the missing namespace here. If I misunderstood anything let me know, but it seemed like an easy fix so I figured why not just PR it instead of opening an issue. 😄

PiMaker commented 1 year ago

works fine with UDONSHARP too, commit message is a bit misleading (it's always declared now, no matter what UDONSHARP is set to), but lgtm. Thanks for the contribution!

shiyouganai commented 1 year ago

works fine with UDONSHARP too, commit message is a bit misleading (it's always declared now, no matter what UDONSHARP is set to), but lgtm. Thanks for the contribution!

Oops, I guess I was sleepy and didn't write clearly :laughing: ; I was referring to how it is needed only when the define is true, but yes it's declared always. You're welcome and thanks for your work on this project, the lighting in my scenes looks fantastic using it! :star2: