search

PiOverFour / MPK-M2-editor

Alternative to the official AKAI MPKMini MkII Editor
GNU General Public License v3.0
87 stars 13 forks source link

add setup.py #10

Closed juliendehos closed 3 years ago

juliendehos commented 3 years ago

Hi, thanks for this nice project. This PR adds a setup file, which can help for packaging the project (works for me, on NixOS).

PiOverFour commented 3 years ago

Hello @juliendehos, thanks for your interest in this project and sorry for not getting back to you sooner, I completely forgot about this PR.

I’ve never packaged a Python project before, but it seems I need to at least add an empty __init__.py file to ui/, so it’s considered a module, otherwise I get an error. Do you observe the same behaviour?

I think it could be better packaged than that, because as is the i18n is not packaged and ui does not seem like a proper module name. I’ll make some more tests when I get the time, but it may not be very soon…

juliendehos commented 3 years ago

Oh yes, the __init__.py file is generally required. I've updated the PR (and tested using debian buster and pyqt 5.14). I don't know how to properly package i18n data but it's indeed a good idea.

PiOverFour commented 3 years ago

I may try to improve the packaging later, but in the meantime I merged in df2ca748ba6fa7ca90b0cf6b35bbe1c2d2d23e2b.

Thanks!