search

PiPHP / GPIO

A PHP library for accessing the GPIO pins on a Raspberry Pi.
MIT License
425 stars 43 forks source link

Add logic for active_low pins #16

Closed ioantotalca closed 3 years ago

ioantotalca commented 7 years ago

Add delay for setDirection, adding logic for active_low pins.

AndrewCarterUK commented 7 years ago

Thanks for this!

Comments inline :)

AndrewCarterUK commented 7 years ago

Another note, would to be possible to update add in unit tests to obtaining full coverage (see here).

It's not a catch all - but it helps prevent things from breaking in future changes! :)

Thanks again

svpernova09 commented 3 years ago

Marking inactive. If this is still valuable please feel free to reopen and address comments. Thanks!