search

PiPHP / GPIO

A PHP library for accessing the GPIO pins on a Raspberry Pi.
MIT License
431 stars 42 forks source link

Allow users to run 7.3, 7.4, or 8.0 #35

Closed svpernova09 closed 4 years ago

svpernova09 commented 4 years ago

I got you some code @garak

svpernova09 commented 4 years ago

Good. But 7.4 is superfluous here, since "^7.3" is including every 7 minor version above 7.2

According to https://getcomposer.org/doc/articles/versions.md#caret-version-range-

Screen Shot 2020-08-10 at 16 25 14

I'm understanding this to mean our PHP versions as stated:

    "require": {
        "php": "^7.3||^7.4||^8.0"
    },

Will be translated as >=7.3 <7.4.0 OR >=7.4 <7.5.0 OR >=8.0 <8.1.0 which will allow any patch version of 7.3, 7.4, or 8.0 PHP release.

garak commented 4 years ago

You didn't read it carefully

svpernova09 commented 4 years ago

You didn't read it carefully

This is not a helpful comment.

garak commented 4 years ago

Just re-read it: you took the rules for zero versions as universal (they aren't). Edit: I'll try to be more specific: ^7.3 means "at least 7.3.0 and below 8"