search

PiPass / blockpage

A temporary unblock solution and blockpage for your Pi-Hole system
BSD 3-Clause "New" or "Revised" License
196 stars 14 forks source link

Recommendation: Allow user configuration from outside of the code. #10

Closed JoeSchubert closed 5 years ago

JoeSchubert commented 5 years ago

I'll try to work on things as I have time... But I would recommend doing something like this: https://github.com/yoinx/PiPass/commit/555c9dcdb8830fc7936d4bd4127b47b4ccde348f

If you make changes to the config.php as you currently have it (to say... update the version) you'll overwrite user changes. Making the end user have to re-change their config after every update. This allows them to make a ~/pi_pass.ini file that will store their settings and override the config.php file. If the field is undefined, it would use your default. Obviously, I only did one field here.

An additional benefit of this is that you could then just git clone/pull the repo then copy the files where they needed to be.

JoeSchubert commented 5 years ago

This could be closed as it was added here: https://github.com/roenw/PiPass/commit/d9e3d79b378a53e0d5c154f8e50349f0ada551b0