PiRSquared17 / activescaffold

Automatically exported from code.google.com/p/activescaffold
MIT License
0 stars 0 forks source link

Custom conditions_for_collection do not propagate to pagination, sorting #755

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Take any controller and configure it as being managed by AS

2. Define override in the controller for conditions_for_collection like so:

def conditions_for_collection
  @conditions
end

3. Create a quick filter like this one. Assume my model has 'status' field.

def expired 
  @conditions = { :status => 'expired'}
  list # call AS's list method
end

This allows me to have a quick link to a filter for AS-scaffolded results via 
http://server/app/my_controller/expired/.

4. Click any of the pagination links or attempt to sort by any column. 

What is the expected output? What do you see instead?
I expect the filter conditions to still apply. What I see is that opening that 
URL loads results and they're properly filtered as expected. However if the 
results are paginated, clicking any of the page links results in the whole 
result set being paginated without the filter applied. Similar thing happens 
when clicking on any column header (i.e. sorting). Sorting happens but without 
the filter @conditions being applied.

What version (or revision) of the product are you using?
Latest master from github (last commit as of jun 24,2010).

If this bug causes an exception, please paste at least the first 20 lines below.
No exceptions. Just doesn't work as one would expect.
Thank you in advance.

Original issue reported on code.google.com by netv...@gmail.com on 4 Jul 2010 at 9:51

GoogleCodeExporter commented 9 years ago
Fixed in eac0c4a

Original comment by sergio.c...@gmail.com on 5 Jul 2010 at 7:38