PiRSquared17 / activescaffold

Automatically exported from code.google.com/p/activescaffold
MIT License
0 stars 0 forks source link

record should be reloaded in case of StaleObjectError #772

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open an edit view (including lock_version) twice (in two different browsers 
or tabs)
2. Edit the first window (change something) and save
3. Edit the second window (change something else) and save

What is the expected output? 
I want an error message about the double edit and the form presenting the data 
coming from step 2.

What do you see instead?
I see the correct error message. But I see my new data, entered in step 3. 

StaleObjectError is used to inform the user, that something has changed in the 
model. But in the current implementation I have no clue, what was the change in 
step 2. In fact, if I hit the save button again, same error message pops out 
and my only chance is to leave the form and try again.
In my opinion, ActiveScaffold should reload the @record in case of a 
StaleObjectError. This way it discards the changes from step 3 and gives the 
user a chance to review the changes from step 2 (and make his changes again)

Original issue reported on code.google.com by koerner....@gmail.com on 7 Apr 2011 at 7:04