search

PiRSquared17 / alembic

Automatically exported from code.google.com/p/alembic
Other
0 stars 0 forks source link

Change names of POD Properties and Samples to accurately reflect the bit-width #114

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently, the names of Properties and Samples of POD types like int, float, 
double, long, etc. are named like:

IntArrayProperty (32-bit)
FloatArrayProperty (32-bit)
DoubleArrayProperty (64-bit)
LongArrayProperty (64-bit)
etc.

with analogous typedefs for typed Samples.

However, they are defined not in terms of the typenames of "int" or "float", 
but rather, explicitly in terms of the PODs in Alembic::Util: int32_t, 
float32_t, float64_t, etc.  So, I'm proposing that we make that explicit in the 
names for the Properties and Samples, eg:

Int32ArrayProperty
UInt32ArrayProperty
Float32ArrayProperty
Float64Property (64-bit float scalar property)
Int64Property
UInt64Property
etc.

This could be done mechanically in just a few steps like:

cd $ALEMBIC_SRC_ROOT
perl -pi -e 's/IntProperty/Int32Property/g' `find * -type f`
# repeat for Floats, Longs, Shorts, etc.

Original issue reported on code.google.com by ard...@gmail.com on 17 Nov 2010 at 12:21