search

PiRSquared17 / alembic

Automatically exported from code.google.com/p/alembic
Other
0 stars 0 forks source link

Schemas in AbcGeom should keep track of times and number of samples as first-class entities #127

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Right now, the way Schemas in AbcGeom deal with time (TimeSamplingType, etc.) 
and number of samples is ad-hoc and idiosyncratic to each Schema, being 
calculated as meta-properties of the Schema's sub-Properties.  This leads to 
some ill-defined and hard to debug behavior.  I propose the following:

1) Schemas in AbcGeom always have a DoubleArrayProperty called "m_sampleTimes" 
which contains the values of each set sample time;

2) Schemas in AbcGeom have an Int64Property called "m_numSamples";

3) Schemas have an m_timeSamplingType member;

4) All sub-Properties are stored with Identity Time Sampling as an 
implementation detail, and the Sample classes and Schemas abstract that away to 
provide a unified and consistent interface for time.

This should both simplify the code in the Schemas for dealing with this issue, 
make it more robust and comprehensible, and also reduce the amount of bytes 
stored in an Archive.

I'm planning on doing this work in my own time over the holiday break.

Original issue reported on code.google.com by ard...@gmail.com on 21 Dec 2010 at 8:00

GoogleCodeExporter commented 9 years ago

Original comment by ard...@gmail.com on 21 Dec 2010 at 8:00

GoogleCodeExporter commented 9 years ago 
Doesn't this preclude the possibility of diferent properties having different 
timeSamples?  or is that something we already do not allow...?

Original comment by tommy.bu...@gmail.com on 21 Dec 2010 at 10:59

GoogleCodeExporter commented 9 years ago

Original comment by ard...@gmail.com on 18 Jan 2011 at 11:32

GoogleCodeExporter commented 9 years ago 
Changing to P1 per our meeting

Original comment by scottmmo...@gmail.com on 28 Jan 2011 at 1:04

GoogleCodeExporter commented 9 years ago 
Tommy: Yes, it would, but there's already no native/easy way to have different 
user-specified time sampling per-property in a Schema.  This wouldn't really be 
a functionality regression.

Original comment by ard...@gmail.com on 24 Mar 2011 at 1:34

GoogleCodeExporter commented 9 years ago 
The time sampling API changes make this not necessary.

Original comment by ard...@gmail.com on 16 May 2011 at 10:37