PiRSquared17 / alembic

Automatically exported from code.google.com/p/alembic
Other
0 stars 0 forks source link

Using CXX_FLAGS yields a broken gcc command when building Alembic #146

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
If I specify CXX_FLAGS (in my case to add an extra include path), then I start 
getting gcc commands with semi-colons in the middle of them, like:

gcc ..... -I/my/custom/path;-Wreturn-type -Werror ...

It seems like it's creating a semi-colon-separated list rather than a single 
string. I don't know nearly enough about CMake to say whether the following 
diff is a "good" change or not, but it gets me going again.

FWIW, I've tried cmake2.8.2 and cmake2.8.4

diff -r c886e5cde592 CMakeLists.txt
--- a/CMakeLists.txt    Thu Mar 17 14:14:43 2011 -0700
+++ b/CMakeLists.txt    Mon Apr 04 13:51:44 2011 +0100
@@ -82,7 +82,7 @@
 ENDIF()

 IF ( NOT WINDOWS )
-  SET( CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} "-Wreturn-type -Werror" )
+  SET( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wreturn-type -Werror" )
 ENDIF()

 IF( ${WINDOWS} )

Original issue reported on code.google.com by robpi...@gmail.com on 5 Apr 2011 at 8:47

GoogleCodeExporter commented 9 years ago
Thanks, Rob.  I've made the change here, and it will be in the next point 
release, coming soon:

http://code.google.com/r/ardent-embic/source/detail?r=49f68a716f9329e4b6e27d9099
fe45dec8a3c7e7

Original comment by ard...@gmail.com on 5 Apr 2011 at 7:29