PiRSquared17 / bpbible

Automatically exported from code.google.com/p/bpbible
Other
0 stars 1 forks source link

Tag not removed or changed when topic or passage is deleted or updated #77

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Tag a verse, for example, Exodus 20:20 and label it "Sin not"
2. In Manage Topics, Select the topic, "Sin not" and delete it.
3. The topic is deleted, but the tag remains on the verse.  Click on the 
verse and this error occurs:

Traceback (most recent call last):
  File "gui\passage_tag.pyo", line 204, in on_left_button_up
  File "manage_topics_frame.pyo", line 93, in select_topic_and_passage
  File "manage_topics_frame.pyo", line 108, in _set_selected_topic
  File "wx\_controls.pyo", line 5492, in SelectItem
ValueError: invalid null reference in method 'TreeCtrl_SelectItem', 
expected argument 2 of type 'wxTreeItemId const &'

What is the expected output? What do you see instead?
I would expect tags to be removed from verses when the topic is deleted.

What version of the product are you using? On what operating system?
0.4.3

Please provide any additional information below.
I am a new user but am impressed with the resources you have so far and 
the portability of BPBible.

Original issue reported on code.google.com by Dennis.Gladden@gmail.com on 18 May 2009 at 4:34

GoogleCodeExporter commented 9 years ago
This is a known issue which has been present since 0.4.  Unfortunately, with our
current technology it is not easily possible to change the tags displayed in the
window without reloading the entire window, which I felt could be very 
disruptive if
you were deleting a few items one after the other.  If you go to another 
chapter and
back to that chapter again then the deleted tag will no longer be displayed.

However, I should probably prevent the exception before 0.4.4.  Thanks for the 
report.

Original comment by jonmmor...@gmail.com on 19 May 2009 at 2:45

GoogleCodeExporter commented 9 years ago
This has more implications than just deletion.  If the passage is edited then 
the tag
should not be displayed in the old passage, but should be displayed in the new 
passage.

As said above, this is currently not supported for performance reasons, but I 
have
fixed the exception in r757, and this fix will be in 0.4.4.

Original comment by jonmmor...@gmail.com on 19 May 2009 at 12:29

GoogleCodeExporter commented 9 years ago
This will be covered by issue 92.

Original comment by jonmmor...@gmail.com on 20 Sep 2010 at 2:04