PiRSquared17 / cing

Automatically exported from code.google.com/p/cing
0 stars 0 forks source link

assignment Critique not listed for cs outside range avg - 4*sd #300

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. load validation report
2. load assignment table

What is the expected output? What do you see instead?
Expected: critique when observed cs outside range avg +- 4*sd.
Observed: critique when observed cs higher than avg + 4*sd, no critique when 
observed cs lower than avg - 4*sd.

Please use labels and text to provide additional information.

Original issue reported on code.google.com by WGTouw on 11 Jul 2011 at 10:19

GoogleCodeExporter commented 9 years ago

Original comment by WGTouw on 11 Jul 2011 at 10:20

GoogleCodeExporter commented 9 years ago
This issue was not because of plus or minus but because the assignments are in 
different lists and CING doesn't pull them out correctly everywhere.

The bug fixes were extensive and have not been fully tested.

Committed to r1031.

Wouter can you please verify by running in tcsh on a VC:

set x = 2k6q
set ch23 = ( `echo $x | cut -c2-3` )
wget http://nmr.cmbi.ru.nl/NRG-CING/input/$ch23/$x.tgz
cing -n $x --initCcpn=$x.tgz --validateImageLess

It takes about a few minutes. Not everything has been fixed but this issue can 
be closed I think.
Then set the status to verified `if you're happy and you know it`.

Original comment by jurge...@gmail.com on 11 Jul 2011 at 1:56