search

PiRSquared17 / flac2all

Automatically exported from code.google.com/p/flac2all
0 stars 0 forks source link

flac tags are not copied when in metadata block 1 #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. try to convert a flac file with tags in metadata block 1
2.
3.

What is the expected output? What do you see instead?
tags present in metadata block 1 should be copied in mp3 file

What version of the product are you using? On what operating system?
v3.38.py on fedora 19

Please provide any additional information below.
example of flac file with data on metadata block 1

[bernard@localhost Test]$ metaflac --list "01 - Track 1.flac" 
METADATA block #0
  type: 0 (STREAMINFO)
  is last: false
  length: 34
  minimum blocksize: 4608 samples
  maximum blocksize: 4608 samples
  minimum framesize: 14 bytes
  maximum framesize: 10943 bytes
  sample_rate: 44100 Hz
  channels: 2
  bits-per-sample: 16
  total samples: 24784200
  MD5 signature: 7d12bc221cef253fbfd9e750e5c75486
METADATA block #1
  type: 4 (VORBIS_COMMENT)
  is last: false
  length: 568
  vendor string: GStreamer encoded vorbiscomment
  comments: 16
    comment[0]: playcount:quodlibet@lists.sacredchao.net=2
    comment[1]: compilation=0
    comment[2]: musicbrainz_discid=ZYzLf7n1gb9dJs3TbhvooCODBQk-
    comment[3]: genre=Classical
    comment[4]: replaygain_track_peak=0.000000
    comment[5]: album=Daniel Barenboim 50 years of performance
    comment[6]: replaygain_album_gain=0.000000
    comment[7]: discid=8310af09
    comment[8]: title=Piano Sonata No.8 "Pathétique" Grave: Allegro di molto e con brio
    comment[9]: artist=Ludwig Van Beethoven
    comment[10]: replaygain_track_gain=0.000000
    comment[11]: artistsort=Beethoven Ludwig Van
    comment[12]: replaygain_album_peak=0.000000
    comment[13]: tracknumber=1
    comment[14]: tracktotal=9
    comment[15]: discnumber=2
METADATA block #2
  type: 1 (PADDING)
  is last: true
  length: 4016

Original issue reported on code.google.com by bernard....@gmail.com on 24 Jun 2014 at 9:17

GoogleCodeExporter commented 9 years ago 
I checked the code and i changed line 104
from  flacdata = os.popen("%smetaflac --list --block-number 2 %s" %
to flacdata = os.popen("%smetaflac --list --block-type=VORBIS_COMMENT %s" %
and all tags are written correctly now.

Thanks a lot for the script, is really helpfull.

Original comment by bernard....@gmail.com on 24 Jun 2014 at 9:33

GoogleCodeExporter commented 9 years ago 
You are very welcome! Thank you for the bug report as well,  it makes the 
entire project better :)

This looks like the same problem as issue 14, so merging the two.

Original comment by i...@ziva-vatra.com on 19 Jul 2014 at 11:18