PiRSquared17 / glu-genetics

Automatically exported from code.google.com/p/glu-genetics
Other
0 stars 0 forks source link

Review fileutils API rename #1

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Based on my own desire to make the fileutils APIs more consistant and from   
feedback from developers, I am proposing the attached renaming, where:

load_list -> list_reader
load_map -> map_reader
load_table -> table_reader
load_table_rows -> table_reader_rows

Backward compatible aliases with deprecation warnings will be preserved 
until just before 1.0 goes into release candidate phase.  Please review.

Original issue reported on code.google.com by bioinformed@gmail.com on 25 Sep 2008 at 3:56

GoogleCodeExporter commented 9 years ago
Attached diff for review

Original comment by bioinformed@gmail.com on 25 Sep 2008 at 3:57

Attachments:

GoogleCodeExporter commented 9 years ago
I like the new APIs.  One additional comment:
Can we merge table_reader with table_rows_reader? In that case, we could wrap 
the 
checking of the first argument either being an iterator(rows) or 
string(filename) 
inside the common new API.

Zhaoming 

Original comment by zwangm...@yahoo.com on 25 Sep 2008 at 7:49

GoogleCodeExporter commented 9 years ago
I decided to split table_row_reader from table_reader to allow other functions 
to
select columns from pre-existing tabular data.  As such, table_reader is 
intended as
an input function and is so named (currently supporting delimited and XLS, but 
more
are certainly possible-- I'm playing with a SQLite adapter now).  
table_row_reader is
used in, e.g., lib.association to further process row data that was previously 
read.
 Rather than merge them again, maybe we just need to rename table_row_reader to
something clearer.  I like having this functionality decoupled from the input 
format,
though it is still convenient to call from table_reader.  How about one of the
following names:

table_columns
table_select_columns
table_generate_columns

?

Or can you think of something better?

Original comment by bioinformed@gmail.com on 25 Sep 2008 at 8:29

GoogleCodeExporter commented 9 years ago
The grand renaming has been applied and released as of 1.0a5.

Original comment by bioinformed@gmail.com on 17 Oct 2008 at 2:37