Improve the style of the default MoinMoin theme 2/2

[GoogleCodeExporter]

MoinMoin ships with a blueish theme that needs some smaller redesign
because of constantly added features that degraded style and usability
in the last years. Your task is to modify the theming file (written in
Python) and the css files to make MoinMoin look nicer.

You find the theming file in `MoinMoin/themes/__init__.py` and
modern.py. The css files are in `wiki/htdocs/modern/css`. The MoinMoin
team will decide if the modifications were significant enough (we
assume that a lot can be made better) to decide whether the task was
successfully fulfilled.

We estimate that this task takes 12h work time and you must complete
this task within 10 days.

 A more detailed description of this issue is available at the
MoinMoin wiki: http://moinmo.in/EasyToDo/ImproveStyleOfModernTheme

This issue is available multiple times. This one is 2 of 2.

Original issue reported on code.google.com by webmas...@alexanderweb.de on 28 Nov 2007 at 9:29

[GoogleCodeExporter]

I claim this task.

Original comment by p...@nikolasbecker.de on 2 Dec 2007 at 1:54

[GoogleCodeExporter]

You got the task, p...@nikolasbecker.de

Original comment by webmas...@alexanderweb.de on 2 Dec 2007 at 9:24

• Changed state: Claimed
• Added labels: ClaimedBy-p...nikolasbecker.de

[GoogleCodeExporter]

Original comment by webmas...@alexanderweb.de on 5 Dec 2007 at 3:50

• Added labels: EndDate-2007-12-12

[GoogleCodeExporter]

Your task is due in a few days.

Please show what you have now so we can check if there are issues and you have 
some
time left to fix them.

Original comment by Thomas.J...@gmail.com on 10 Dec 2007 at 12:32

[GoogleCodeExporter]

OK. I'm done. I hope that I made the diff correct.

There is a problem with the logo and the #header background. See:
http://moinmo.in/MoinMoinBugs/LogoHasSharpEdges

Original comment by p...@nikolasbecker.de on 11 Dec 2007 at 10:31

Attachments:

• bluemodern_theme
• moinmoin.png
• blue_theme_images.tar.gz

[GoogleCodeExporter]

Hmm, there must have gone sth wrong. The diff contains some other code, not 
yours.

Maybe read the mercurial page on the moinmoin wiki (again) and meet us on IRC 
if you
have questions. The patch should be named *.patch.

Images should be in PNG format, not GIF. The right images are much bigger than 
the
left ones? Is using an image the only way to do this? CSS?

navibar-bg.gif is just blue colour, isn't it? Can't this be better done using 
CSS?

Original comment by Thomas.J...@gmail.com on 12 Dec 2007 at 3:36

[GoogleCodeExporter]

>Hmm, there must have gone sth wrong. The diff contains some other code, not 
yours.
Oh - I'm sorry. Can I delete the attachment?

>Maybe read the mercurial page on the moinmoin wiki (again) and meet us on IRC 
if you
have questions. The patch should be named *.patch.
I'll do this!

>Images should be in PNG format, not GIF.
I' can save them as PNG, too - but IE has problems with the transparent edges.

> The right images are much bigger than the left ones?
Yes - thats right.

>Is using an image the only way to do this? CSS?
It is possible to get round edges with CSS+JavaScript - but I think this is the
better way.

>navibar-bg.gif is just blue colour, isn't it? Can't this be better done using 
CSS?
No! It's because the "active Tab" has no border at his bottom.

Original comment by p...@nikolasbecker.de on 12 Dec 2007 at 11:11

[GoogleCodeExporter]

So. I hope this is the right file.

Original comment by p...@nikolasbecker.de on 12 Dec 2007 at 11:39

Attachments:

• blue.diff

[GoogleCodeExporter]

I suggest you read your diff. It will show you some place where 
formatting/indenting
is wrong (and please don't use tabs).

That MS IE hack also seems to have an erroneous "n" char in there.

The MS IE stuff, shouldn't it be in the msie.css file?

You also still have to create your homepage on: http://moinmo.in/NikolasBecker

Original comment by Thomas.J...@gmail.com on 13 Dec 2007 at 8:30

[GoogleCodeExporter]

Ah, I found the failure: I attached the diff of the css-file, I created for 
MM1.5. 

Tomorrow I will upload the right file for MM1.6.

Original comment by p...@nikolasbecker.de on 14 Dec 2007 at 7:26

[GoogleCodeExporter]

Nikolas, please hurry, you are late.

Your task is overdue and must be reopened tomorrow if you don't provide final 
results
and fullfil all stuff required by task description and google's and our general 
rules.

Original comment by Thomas.J...@gmail.com on 15 Dec 2007 at 8:55

• Changed state: ActionNeeded

[GoogleCodeExporter]

OK. I think now it's finally done.

The diff is attached, the wiki-page is created and I checked the formatting.

Original comment by p...@nikolasbecker.de on 15 Dec 2007 at 10:45

Attachments:

• modern_css_blue2.diff

[GoogleCodeExporter]

Hi thanks for the patch, 

please can you check quicklinks they are not separated from the navi_bar. And 
do you
have seen that the edit_bar does not change it's alignment in rtl.

Original comment by rb.p...@gmail.com on 16 Dec 2007 at 12:17

[GoogleCodeExporter]

I think the rtl issue is irrelevant currently. The quicklinks issue is a major 
one 
though.
And I have another issue with the tabs: if there is no background image 
(because 
e.g. images are disabled or not yet loaded), the background colour should be 
lighter 
than the current one to fix the bad contrast.

Original comment by webmas...@alexanderweb.de on 16 Dec 2007 at 7:44

[GoogleCodeExporter]

>please can you check quicklinks they are not separated from the navi_bar.
Of course, they are not seperated - but I think they do not have to be 
seperated. The
quicklinks are just a part of the navigation.

>And do you have seen that the edit_bar does not change it's alignment in rtl.
I fixed it - but there is already a problem with the navibar in rtl. At the 
moment I
cannot see the false, but I hope I'll find it.

Original comment by p...@nikolasbecker.de on 16 Dec 2007 at 10:02

Attachments:

• modern_css_blue2.1.diff

[GoogleCodeExporter]

Quicklinks need to have a different colour. Does this work?

Original comment by webmas...@alexanderweb.de on 16 Dec 2007 at 10:15

[GoogleCodeExporter]

Any answer to comment 16?

Original comment by Thomas.J...@gmail.com on 18 Dec 2007 at 5:37

[GoogleCodeExporter]

This task is overdue 6 days already. I did not close it yet because we had been 
blocking it with reviews a few times (not too long, though). So I think I will 
reopen this task in a bit less than 5 hours again if there is no answer to our 
two 
days old questions.

Original comment by webmas...@alexanderweb.de on 18 Dec 2007 at 6:17

[GoogleCodeExporter]

Sorry! I' ll upload it in one hour.

Original comment by p...@nikolasbecker.de on 18 Dec 2007 at 9:39

[GoogleCodeExporter]

Here it is.

Sorry again for not answering. I tried to change the #pageline's 
background-color,
when a .userlink becames current - but I searched out it is impossible just 
with CSS.

For this #pageline needs to be in a special class, when a userlink is selected. 
-
This must changed in the python code ...

Original comment by p...@nikolasbecker.de on 18 Dec 2007 at 10:22

Attachments:

• modern_css_blue2.2.diff
• navi-tab-left_quick.gif
• navi-tab-right_quick.gif

[GoogleCodeExporter]

Hmm? I do not understand your problem ...
Also I do not see that you fixed the black on dark blue issue that comes up 
when 
images are disabled. Is it related to that issue?

Original comment by webmas...@alexanderweb.de on 18 Dec 2007 at 11:33

[GoogleCodeExporter]

"black on dark blue issue"-fix will be released tomorrow

Original comment by p...@nikolasbecker.de on 19 Dec 2007 at 5:05

[GoogleCodeExporter]

here it is: 2.3

Original comment by p...@nikolasbecker.de on 20 Dec 2007 at 11:53

Attachments:

• modern_css_blue2.3.diff
• img2.3.tar.gz

[GoogleCodeExporter]

Very nice. The only negative issue is the grey colour of the "Search" token in 
the 
search field that is too light (bad contrast) but I think we can fix that 
ourselves.
(Or you can fix that if you want to continue contributing to this project :))

So we should think about whether this can be merged into the default theme for 
1.6

The student has completed his task.

Original comment by webmas...@alexanderweb.de on 22 Dec 2007 at 12:39

• Changed state: Closed