search

PiRSquared17 / magento-w2p

Automatically exported from code.google.com/p/magento-w2p
0 stars 0 forks source link

Theme customization #295

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
There is a good popular theme under 
http://www.magentocommerce.com/magento-connect/HelloThemes.com/extension/3673/he
llowired_free_theme_1_4

We need to customize and release it with the necessary changes for other 
customers to use. It's a good theme.

Make sure one step, 2-step and field highlighters work.

Needs to be documented and checked into SVN as a base and in the changed form.

Post diffs. We'll use it for a help post.

Original issue reported on code.google.com by zetapri...@gmail.com on 27 Aug 2010 at 5:59

GoogleCodeExporter commented 9 years ago 
SVN release
http://code.google.com/p/magento-w2p/source/detail?r=984

to test:
http://ec2-174-129-95-130.compute-1.amazonaws.com/magedev/

Original comment by trilobit.alex@gmail.com on 31 Aug 2010 at 11:43

GoogleCodeExporter commented 9 years ago 
See a comment on http://code.google.com/p/magento-w2p/source/detail?r=984

Original comment by zetapri...@gmail.com on 31 Aug 2010 at 9:00

GoogleCodeExporter commented 9 years ago 
SVN release
http://code.google.com/p/magento-w2p/source/detail?r=988

to test:
http://ec2-174-129-95-130.compute-1.amazonaws.com/magedev/

Original comment by trilobit.alex@gmail.com on 1 Sep 2010 at 10:36

GoogleCodeExporter commented 9 years ago 
Do we really need local.xml in there ?

Original comment by zetapri...@gmail.com on 1 Sep 2010 at 6:27

GoogleCodeExporter commented 9 years ago 
OK, I see, we do

Original comment by zetapri...@gmail.com on 2 Sep 2010 at 4:05

GoogleCodeExporter commented 9 years ago 
1. Image fields have "Browse" showing up two times instead of the "Upload" 
button (image_field_1.png).

2. Add a few pixels above each input field. The way it is now, they are too 
close to each other and one might mistake which field name goes with which 
field (field_spacing_1.png).

3. Share link expands in a new row (share_1.png).

4. Highlighter doesn't work. Tried assigning "default" and "hellowired" themes 
under zp-w2p (theme_1.png). No changes.

5. Can you add the loader to the "Update button" (loader_1.png)?

6. Download extension button in the right column should be a few pixels wider. 
It repeats it self right now (column_1.png).

Original comment by agur...@gmail.com on 2 Sep 2010 at 9:53

Attachments:

GoogleCodeExporter commented 9 years ago 
2. Add a few pixels above each input field. The way it is now, they are too 
close to each other and one might mistake which field name goes with which 
field (field_spacing_1.png).

Same problem exists in our zptheme.

6. Download extension button in the right column should be a few pixels wider. 
It repeats it self right now (column_1.png). 

Need to remove border from image in zptheme, will do it.

Original comment by Anatoly....@gmail.com on 3 Sep 2010 at 4:37

GoogleCodeExporter commented 9 years ago 
re #7 
Are you saying the problems are inherited from zptheme ?

Original comment by zetapri...@gmail.com on 3 Sep 2010 at 5:45

GoogleCodeExporter commented 9 years ago 
> Are you saying the problems are inherited from zptheme?

Yes, it is.

>> 6. Download extension button in the right column should be a few pixels 
wider.
>> It repeats it self right now (column_1.png). 
>
> Need to remove border from image in zptheme, will do it.

The file is in JPEG format. Atanas, could you make it an PNG image without a 
border?

Original comment by Anatoly....@gmail.com on 7 Sep 2010 at 4:10

GoogleCodeExporter commented 9 years ago

Original comment by agur...@gmail.com on 7 Sep 2010 at 8:53

Attachments:

GoogleCodeExporter commented 9 years ago 
Fixed
http://ec2-174-129-95-130.compute-1.amazonaws.com/magedev/index.php/prod-2.html

You can use zpadvancedtheme from zp-w2p package to highlighter.

SVN releases:
hellowired - http://code.google.com/p/magento-w2p/source/detail?r=1054
zp-w2p     - http://code.google.com/p/magento-w2p/source/detail?r=1055

Original comment by trilobit.alex@gmail.com on 17 Sep 2010 at 4:03

GoogleCodeExporter commented 9 years ago 
Why did we need to change OUR theme?
The task was about customization of some other theme.

Original comment by zetapri...@gmail.com on 17 Sep 2010 at 10:26

GoogleCodeExporter commented 9 years ago 
To answer my own question 
http://code.google.com/p/magento-w2p/source/detail?r=1055 is the base theme for 
hellowwired

Original comment by zetapri...@gmail.com on 17 Sep 2010 at 1:05

GoogleCodeExporter commented 9 years ago

Original comment by zetapri...@gmail.com on 17 Sep 2010 at 1:08

GoogleCodeExporter commented 9 years ago 
We may have a problem with the way the process is described in Wiki. We need to 
review the documentation once the theme tests OK.

Original comment by zetapri...@gmail.com on 17 Sep 2010 at 1:11

GoogleCodeExporter commented 9 years ago 
1. Add a top and bottom border on the extension button as well (ext_button.png).

2. There is a missing image on category page. Ex:
http://ec2-174-129-95-130.compute-1.amazonaws.com/magedev/index.php/catalog/cate
gory/view/s/test/id/3/
Shows up as missing in IE and Chrome (customer_service.png).

3. 2steptheme shows a blank (add to cart) block on personalization page 
(add_to_cart.png):
http://ec2-174-129-95-130.compute-1.amazonaws.com/magedev/index.php/catalog/prod
uct/view/id/8/s/prod-y/category/3/?personalization=1

Note. Havent tested FancyBox behavior since it is not implemented. Is it 
influenced by this theme in some way. If so, we should also try it on this 
theme.

Original comment by agur...@gmail.com on 20 Sep 2010 at 9:24

Attachments:

GoogleCodeExporter commented 9 years ago 
The fancybox opens up in a new tab/window. Click on the EDIT link in the image 
library scroll on this product:
http://ec2-174-129-95-130.compute-1.amazonaws.com/magedev/index.php/multi-image.
html

Original comment by agur...@gmail.com on 20 Sep 2010 at 9:45

GoogleCodeExporter commented 9 years ago

Original comment by zetapri...@gmail.com on 20 Sep 2010 at 11:01

GoogleCodeExporter commented 9 years ago 
1. fixed
2. fixed
3. because "add to cart" button is hidden by our extension, but not all block
The fancybox - fixed

Original comment by trilobit.alex@gmail.com on 7 Oct 2010 at 2:12

GoogleCodeExporter commented 9 years ago

Original comment by zetapri...@gmail.com on 7 Oct 2010 at 2:28

GoogleCodeExporter commented 9 years ago 
1. Image editing menu is misaligned. Second row goes down and gets hidden by 
the scroll when there is more than one image in the library 
(editing_menu_hidden.png).

2. Can't reach the images. Not sure if this is a theme problem but earlier I 
got them in a new window/tab. Now, the fancybox appears but never finishes 
loading (fancybox_loader.png).

3. "Proceed to checkout" button turns invisible on hover (checkout.png). Same 
goes for "Place order" button (order.png)

4. Make order number orange color on order confirmation page 
(order_number.png). Customers need to know it is a link to order details. Same 
goes for links to generated files on order details page (generated_files.png) 
and link to PDF proof (pdf_prrof.png).

5. How come there are no order previews on order details page 
(order_previews.png)?

Original comment by agur...@gmail.com on 7 Oct 2010 at 9:20

Attachments:

GoogleCodeExporter commented 9 years ago 
Create SVN folder "Themes" under "branches" and move the theme there.

Original comment by zetapri...@gmail.com on 9 Oct 2010 at 9:26

GoogleCodeExporter commented 9 years ago

Original comment by zetapri...@gmail.com on 11 Oct 2010 at 10:15

GoogleCodeExporter commented 9 years ago 
Can I get a preview link? Is there an instance running?

Original comment by jamb...@gmail.com on 11 Oct 2010 at 12:45

GoogleCodeExporter commented 9 years ago 
Some observations.
Hello themes are using jQuery, it is loaded on every page (almost). They also 
use fancybox. Web-to-print also uses these components (and some more but they 
do not conflict) and loads them on some pages - product view for example. When 
both the theme and w2p load these files they do not behave correctly. The way I 
went to fix this is to update local.xml in corresponding Hello theme and remove 
all inclusions of jQuery and fancybox since they are already included from 
page.xml. Since Hello themes are a bit out of date, both jQuery and fancybox 
could be out of date (they were in HelloGlam) therefore I recommend changing 
page.xml too and instead of default jQuery and fancybox load w2p ones. Provided 
that default fall-back theme is set to any of w2p themes that should work.

Original comment by jamb...@gmail.com on 13 Oct 2010 at 10:32

GoogleCodeExporter commented 9 years ago 
HelloWired is currently implemented as a theme in zp-w2p package where zptheme 
is actually default theme.
The problem is that web to print when installed does not create or update 
zp-w2p package but installs its theme files in default package. 
This means that if used as it is now, theme files will not be updated and have 
to be modified by hand.
That is not very customer friendly. So options are 2:
1. Make w2p create a package which is to be used for installing themes which 
extend zptheme. 
2. Do not install themes in this custom package.

Original comment by jamb...@gmail.com on 13 Oct 2010 at 10:41

GoogleCodeExporter commented 9 years ago

Original comment by zetapri...@gmail.com on 14 Oct 2010 at 8:33

GoogleCodeExporter commented 9 years ago 
1. see comment #22
2. change hellowired to work with inheritance, remove zp-theme files

Original comment by zetapri...@gmail.com on 14 Oct 2010 at 8:55

GoogleCodeExporter commented 9 years ago 
Point 4 from comment 21 was moved to Issue #336.

Original comment by zetapri...@gmail.com on 15 Oct 2010 at 5:58

GoogleCodeExporter commented 9 years ago 
Most if not issues are addressed. Revision link:
http://code.google.com/p/magento-w2p/source/detail?r=1094
HelloGlam theme installed on magedev before testing HelloWired need 
to reassign as default theme in admin.

Original comment by jamb...@gmail.com on 15 Oct 2010 at 6:06

GoogleCodeExporter commented 9 years ago 
Tested on FF, Chrome and IE at
http://ec2-174-129-95-130.compute-1.amazonaws.com/magedev/

1. In FF, IE and Chrome, the large generated preview fancybox shows up buggy. 
Positioned vertically instead of horizontally(large_generated_preview.png). 
Generate a preview and click to open it in a larger view.

2. In FF, when I open image editing fancybox, I see prev/next arrows. Why are 
they there (arrows.png)? This is for viewing multipage templates, not when 
editing image library items.

3. In IE, the order details page does not show the order previews like other 
browsers do (ie_order_previews.png).

Original comment by agur...@gmail.com on 18 Oct 2010 at 1:33

Attachments:

GoogleCodeExporter commented 9 years ago 
Tested on FF, Chrome and IE at
http://ec2-174-129-95-130.compute-1.amazonaws.com/magedev/

1. In FF, IE and Chrome, the large generated preview fancybox shows up buggy. 
Positioned vertically instead of horizontally(large_generated_preview.png). 
Generate a preview and click to open it in a larger view.

2. In FF, when I open image editing fancybox, I see prev/next arrows. Why are 
they there (arrows.png)? This is for viewing multipage templates, not when 
editing image library items.

3. In IE, the order details page does not show the order previews like other 
browsers do (ie_order_previews.png).

Original comment by agur...@gmail.com on 18 Oct 2010 at 1:36

Attachments:

GoogleCodeExporter commented 9 years ago 
Now I might be wrong but 
http://ec2-174-129-95-130.compute-1.amazonaws.com/magedev seems reseted to me.

Original comment by jamb...@gmail.com on 1 Nov 2010 at 8:15

GoogleCodeExporter commented 9 years ago 
Yes, you are right.

Original comment by Anatoly....@gmail.com on 1 Nov 2010 at 8:46

GoogleCodeExporter commented 9 years ago 
Is everything up to comment 32 fixed?

We may need to take this last comment into a separate issue if this is still 
valid.

Original comment by zetapri...@gmail.com on 8 Nov 2010 at 10:58

GoogleCodeExporter commented 9 years ago

Original comment by zetapri...@gmail.com on 13 Dec 2010 at 2:02

GoogleCodeExporter commented 9 years ago 
Need to install it to an instance an re-test.

Original comment by Anatoly....@gmail.com on 10 Jan 2011 at 1:59

GoogleCodeExporter commented 9 years ago 
Let's drop it.
HelloWired is a toast anyway. HelloGlam will need work for one of customers 
soon.

Original comment by zetapri...@gmail.com on 11 Jan 2011 at 5:14