PiRSquared17 / marave

Automatically exported from code.google.com/p/marave
GNU General Public License v2.0
0 stars 0 forks source link

Support RTL languages #69

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Now Marave doesn't have full support for RTL languages like Arabic. You can
see that in screen shots comparing with Kwrite.
I have attached a test text arabic file.

Original issue reported on code.google.com by Fahad.Al...@gmail.com on 23 Feb 2010 at 11:58

Attachments:

GoogleCodeExporter commented 9 years ago
Indeed it is broken. I am looking at it right now.

Original comment by roberto.alsina on 23 Feb 2010 at 12:30

GoogleCodeExporter commented 9 years ago
Looks like a Qt bug:

http://is.gd/8ZYu9

Luckily there seems to be a simple workaround. Could you try r392?

Original comment by roberto.alsina on 23 Feb 2010 at 12:50

GoogleCodeExporter commented 9 years ago

Original comment by roberto.alsina on 23 Feb 2010 at 2:36

GoogleCodeExporter commented 9 years ago
The widget layout has to be mirrored when using RTL.

Original comment by roberto.alsina on 23 Feb 2010 at 2:41

GoogleCodeExporter commented 9 years ago
As of r395, the on-screen layout should be mirrored when using RTL languages.

If there's anything that looks weird, post it in this issue.

Original comment by roberto.alsina on 23 Feb 2010 at 4:17

GoogleCodeExporter commented 9 years ago
It doesn't even lunch now. see the output:

linuxcrunch@linux-id5y:~/tmp/marave-0.6/marave-read-only> ./marave-editor       

Using non-canvas editor                                                         

Traceback (most recent call last):                                              

  File "./marave-editor", line 7, in <module>                                    
    main()                                                                       
  File "/home/linuxcrunch/tmp/marave-0.6/marave-read-only/marave/main.py", line 1396,
in main
    window=MainWidget(opengl=options.opengl, canvaseditor=options.canvas)           

  File "/home/linuxcrunch/tmp/marave-0.6/marave-read-only/marave/main.py", line 497,
in __init__
    self.prefsWidget=PrefsWidget(self._scene,mainwindow=self)
  File "/home/linuxcrunch/tmp/marave-0.6/marave-read-only/marave/main.py", line 77,
in __init__
    self.loadPlugins()
  File "/home/linuxcrunch/tmp/marave-0.6/marave-read-only/marave/main.py", line 95,
in loadPlugins
    self.mainwindow.layoutButtons()
  File "/home/linuxcrunch/tmp/marave-0.6/marave-read-only/marave/main.py", line 664,
in layoutButtons
    self.containerLayout.addItem(self.editor.proxy)
AttributeError: 'FunkyEditor' object has no attribute 'proxy'

Original comment by Fahad.Al...@gmail.com on 23 Feb 2010 at 6:32

GoogleCodeExporter commented 9 years ago
Ok, I broke Qt 4.5 support again. I'll fix it in a minute.

Original comment by roberto.alsina on 23 Feb 2010 at 6:39

GoogleCodeExporter commented 9 years ago

Original comment by roberto.alsina on 23 Feb 2010 at 6:40

GoogleCodeExporter commented 9 years ago
Could you try r401?

Original comment by roberto.alsina on 23 Feb 2010 at 6:59

GoogleCodeExporter commented 9 years ago
I will tested when I change my setting to full Arabic setting but what I want an
option like what is in Kwrite see the screenshot.

You can read more about the auto detecting for BiDi direction and kwrite here:
http://bugs.kde.org/show_bug.cgi?id=156093

Original comment by Fahad.Al...@gmail.com on 23 Feb 2010 at 7:42

Attachments:

GoogleCodeExporter commented 9 years ago
I don't see any LTR/RTL options there?

Original comment by roberto.alsina on 23 Feb 2010 at 8:31

GoogleCodeExporter commented 9 years ago
There is already support to switch from RTL to LTR in a document using the RMB 
menu, 
but I have no idea of how these things work.

Original comment by roberto.alsina on 23 Feb 2010 at 8:38

GoogleCodeExporter commented 9 years ago
In r418, I switch the previous/next icons when in a RTL locale.

Original comment by roberto.alsina on 25 Feb 2010 at 3:49