Browse/Search & Attach Files function returns error message, while Upload and Attach File returns properly

[GoogleCodeExporter]

What steps will reproduce the problem?
1.Hover mouse over Browse/Search & Attach Files folder icon.
2.Click mouse on Browse/Search & Attach Files folder icon.
3.See error message.

What is the expected output? What do you see instead?

Expected output is to be able to attach files previously uploaded.

What is seen instead is:

"Catchable fatal error: Argument 1 passed to 
PageAttachment_BrowseSearch_ImageListPager::__construct() must be an instance 
of _IContextSource, instance of RequestContext given, called in 
/home/myusername/public_html/extensions/PageAttachment/browse-search/ListFiles.p
hp on line 74 and defined in 
/home/myusername/public_html/extensions/PageAttachment/browse-search/ImageListPa
ger.php on line 47"

What version of the product are you using? On what operating system?

  PageAttachment version  :3.0.0-php-5.2.3
  MediaWiki version       :1.20.2
  PHP version             :5.3.19
  Operating System name   :MySQL
  Operating System version:5.5.28-cll

Please provide any additional information below.

Upload and Attach Files returns properly. The only problem is the Browse/Search 
& Attach Files.
I much appreciate the support.

Original issue reported on code.google.com by scriptur...@gmail.com on 12 Jan 2013 at 3:33

[GoogleCodeExporter]

Hi  scripturememory2:

Thank you for reporting this bug.  It is a bug the in the 
"Ant"(http://ant.apache.org/) script that I created to transform the "3.0.0" 
version into "3.0.0-php-5.2.3" to make it compatible with PHP 5.2.3

Will fix this as soon as possible and upload a new version.

Sincerely yours,

Aldrin

Original comment by Aldrin.Baroi@gmail.com on 13 Jan 2013 at 8:18

• Changed state: Accepted
• Added labels: Milestone-3.0.1-php-5.2.3

[GoogleCodeExporter]

Aldrin,

That would be great. Thanks.

AC

On Sun, Jan 13, 2013 at 12:18 AM,
<mediawiki-page-attachment@googlecode.com>wrote:

Original comment by scriptur...@gmail.com on 13 Jan 2013 at 8:20

[GoogleCodeExporter]

This is fixed.

Uploaded new version:  3.0.1-php-5.2.3

Original comment by Aldrin.Baroi@gmail.com on 14 Jan 2013 at 12:34

• Changed state: Fixed

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

It can be downloaded at: 
http://code.google.com/p/mediawiki-page-attachment/downloads/detail?name=mediawi
ki-page-attachment-3.0.1-php-5.2.3.zip&can=2&q=

Original comment by scriptur...@gmail.com on 14 Jan 2013 at 12:47

[GoogleCodeExporter]

Aldrin,

It is only partially fixed. When I click the folder icon for Browse/Search
& Attach, it does go to a File List with an attachment column. However,
when a search is performed for a certain filename or even the next page of
attachments is called if there are more than the default number (20) in the
filelist, that column disappears and it is no longer possible to attach a
file using this function. Sorry to "bug" you. :)

AC

On Sun, Jan 13, 2013 at 4:34 PM,
<mediawiki-page-attachment@googlecode.com>wrote:

Original comment by scriptur...@gmail.com on 14 Jan 2013 at 1:07

[GoogleCodeExporter]

Hi AC:

No, thank you.  I only tested with handful of files... 

Let me check what remains to be fixed.

Sincerely yours,

Aldrin

Original comment by Aldrin.Baroi@gmail.com on 14 Jan 2013 at 1:23

• Changed state: Reopened

[GoogleCodeExporter]

Hi AC:

Found the issue:  On search and on clicking page navigation link replaces 
"PageAttachment"'s custom code with MediaWiki's default code.

Need to figure out how to fix this.

Sincerely yours,

Aldrin

Original comment by Aldrin.Baroi@gmail.com on 14 Jan 2013 at 1:47

[GoogleCodeExporter]

After further testing:

    1) No issue on MediaWiki 1.19.x.

    2) This is impacting MediaWiki 1.20.x 

Original comment by Aldrin.Baroi@gmail.com on 14 Jan 2013 at 1:56

[GoogleCodeExporter]

Original comment by Aldrin.Baroi@gmail.com on 14 Jan 2013 at 1:57

• Added labels: Milestone-3.0.1

[GoogleCodeExporter]

Looks like in MediaWiki 1.20, in "ImageListPager" class, NEW "getTitle()" 
method now has hardcode special page title "ListFiles".  Not Good!!!  Why 
MediaWiki developers did that!!!

Need to figure out, what is the best way to handle this.  As last resort, will 
override the "getTitle()" method altogether and hardcode 
"PageAttachmentListFiles" in there.  In addition, need to check whether this 
change would also work for MediaWiki 1.19 or not; otherwise, have to create a 
separate version for MediaWiki 1.20.

Original comment by Aldrin.Baroi@gmail.com on 14 Jan 2013 at 3:36

[GoogleCodeExporter]

Hi AC:

In my tests, the issues seem to be fixed.  Would you please check and let me 
know.

Uploaded new version: 3.0.2-php-5.2.3

Sincerely yours,

Aldrin

Original comment by Aldrin.Baroi@gmail.com on 14 Jan 2013 at 6:29

• Added labels: Milestone-3.0.2-php-5.2.3, Milestone-3.0.2
• Removed labels: Milestone-3.0.1-php-5.2.3, Milestone-3.0.1

[GoogleCodeExporter]

Browse & Attach appears to be working well but the Search function is
disabled. It does not return anything, no matter input to Search in File
list. The manual turning from page to page works, but not the search. I
truly appreciate the kind help thus far.

AC

On Sun, Jan 13, 2013 at 10:29 PM,
<mediawiki-page-attachment@googlecode.com>wrote:

Original comment by scriptur...@gmail.com on 14 Jan 2013 at 7:13

[GoogleCodeExporter]

Hi AC:

Did some testing and yes code need to be modified.

However, search is not working for me at all when I use "File List" under 
"Special" pages. I tried it on MediaWiki 1.17, 1.18, 1.19, and 1.20.  
PageAttachment "Browse Search/Attach" is based on "File List".  Is search work 
for you in "File List" special page? 

Sincerely yours,

Aldrin

Original comment by Aldrin.Baroi@gmail.com on 16 Jan 2013 at 6:43

[GoogleCodeExporter]

Hi Aldrin,

Yes, special:filelist search works for me outside of "Browse/Search Attach"
in PageAttachment.

Original comment by scriptur...@gmail.com on 16 Jan 2013 at 5:12

[GoogleCodeExporter]

Hi AC:

Still cannot get the search on Special:FileList to work.  So, don't know if the 
updated code works or not.

When you install the wiki, did you choose database type "binary" or "utf-8"?

Sincerely yours,

Aldrin

Original comment by Aldrin.Baroi@gmail.com on 18 Jan 2013 at 3:58

[GoogleCodeExporter]

Original comment by Aldrin.Baroi@gmail.com on 21 Jan 2013 at 7:33

• Added labels: Milestone-3.1.0-php-5.2.3, Milestone-3.1.0
• Removed labels: Milestone-3.0.2-php-5.2.3, Milestone-3.0.2

[GoogleCodeExporter]

Search is now working.

Fixed.

Database character set need to be "UTF-8" for search function to work!!!

Original comment by Aldrin.Baroi@gmail.com on 21 Jan 2013 at 9:47

• Changed state: Fixed