Identify tool queries scale-dependent data layers when the map is not within the appropriate scale range

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Add a data layer with a scale dependency (e.g., Shoreline Change Transects).
2. Zoom so that the map is not within the appropriate scale range for the data 
layer with a scale dependency (e.g., zoom farther out than 1:20,000 so that the 
Shoreline Change Transects data layer is not drawn on the map and its icon in 
the "Active data layers" window has a yellow exclamation point).
3. Use the "Identify" tool to identify features. The data layer with the scale 
dependency will appear in the query results. If the data layer name is selected 
in the "At a glance" table, the feature details will appear and the features 
will be highlighted on the map even though the features were not being drawn on 
the map.

What is the expected output? What do you see instead?
The expected output is that the "Identify" tool would not query active data 
layers with scale dependencies if the map was not within the appropriate scale 
range. Instead, the "Identify" tool queries active data layers with scale 
dependencies even if the map is not within the appropriate scale range.

Please use labels and text to provide additional information.
Tested MORIS v. 0.35 on Windows 7 and Firefox 3.16.15.

Original issue reported on code.google.com by emily.hu...@state.ma.us on 8 Mar 2011 at 10:23

[GoogleCodeExporter]

Now that the output of the slice_getcaps.pl contains min and max scale info 
again, can you use it?  For example: 
http://maps.massgis.state.ma.us/temp/OL_MORIS_cache/massgis_GISDATA.TRANSECTS_AR
C.GISDATA.TRANSECTS_ARC__Default.xml 

Original comment by Aleda.Fr...@state.ma.us on 22 Aug 2011 at 6:49

[GoogleCodeExporter]

Table shows 'not visible at scale' for identify requests that are out of scale. 
 I won't lie to you . . . I'm still allowing the request to go through to the 
server, but I'm not showing the result.

Committed revision 67.

Original comment by cpl...@gmail.com on 22 Aug 2011 at 8:49

[GoogleCodeExporter]

Tried in IE8 - works great.

Original comment by Aleda.Fr...@state.ma.us on 24 Aug 2011 at 6:16

[GoogleCodeExporter]

Wait - I see the appropriate text.  But I'm still allowed to click on it and 
the request happens and it shows up in the table and map.  Can we stop that?  
See screenshot. 

Original comment by Aleda.Fr...@state.ma.us on 24 Aug 2011 at 6:17

Attachments:

• identify_on_invisible_features.JPG

[GoogleCodeExporter]

Good catch.

Committed revision 72.

Original comment by cpl...@gmail.com on 24 Aug 2011 at 6:29

• Changed state: Fixed

[GoogleCodeExporter]

Something weird is going on (Firefox 6).
I drew Transects and was zoomed out and the identify behaved well this time - 
it told me I couldn't see the features, even when I highlighted the row.
Then I zoomed in so I could see the Transects to make sure a regular Identify 
would still work.  When I draw a small box I get too many features in the set. 
When I highlight some of them they are clearly out of the box.  Every time I do 
an identify I get more and more and more features - as if they are accumulating.
See attachment.  

Original comment by Aleda.Fr...@state.ma.us on 25 Aug 2011 at 2:06

Attachments:

• too_many_features_identify.JPG

[GoogleCodeExporter]

Well, poo.  This is an artifact from my attempt to be clever and meet the needs 
of another issue where a user does a 'point' query (which is really a small 
bbox) and I turn it into a bigger bbox.

What was happening here, is that the bbox you were drawing was actually smaller 
than the minimum bbox I was assuming for a point query.

I've commented out the grow-the-point-bbox code now, and it should fix this.

I'll reopen the other issue while I ponder how to fix it.

Original comment by cpl...@gmail.com on 25 Aug 2011 at 2:53

[GoogleCodeExporter]

Committed revision 78.

Original comment by cpl...@gmail.com on 25 Aug 2011 at 2:53

[GoogleCodeExporter]

OK, Identify works properly again for Transects. Firefox 6.

Original comment by Aleda.Fr...@state.ma.us on 25 Aug 2011 at 3:25

[GoogleCodeExporter]

IE9 gives me "not visible at this scale."  If I persist and click on the the 
layer regardless, I get "The row has no features. No details will be fetched." 
That's the same message given for a layer that's simply not present in the view.

Would changing the text to "This datalayer is not visible at this scale.  Zoom 
in to view features." be clearer?

Original comment by Bucke...@gmail.com on 26 Aug 2011 at 2:02

[GoogleCodeExporter]

/\  that's me

Original comment by daniel.s...@state.ma.us on 26 Aug 2011 at 2:21

[GoogleCodeExporter]

That's a nice message.  

Original comment by Aleda.Fr...@state.ma.us on 26 Aug 2011 at 3:14

[GoogleCodeExporter]

Done.

Committed revision 86.

Original comment by cpl...@gmail.com on 5 Sep 2011 at 7:30

[GoogleCodeExporter]

I see the new message.

Original comment by Aleda.Fr...@state.ma.us on 8 Sep 2011 at 7:49

[GoogleCodeExporter]

A user could be zoomed in too close to view a layer with a scale dependency, so 
could the pop-up message please be changed to "This data layer is not visible 
at this scale."

Original comment by emily.hu...@state.ma.us on 26 Sep 2011 at 2:05

[GoogleCodeExporter]

Fixed.

v. 0.76
Committed revision 188.

Original comment by cpl...@gmail.com on 17 Nov 2011 at 1:14

[GoogleCodeExporter]

Verified. Text was updated in pop-up message.

Tested MORIS v. 0.77 with Firefox 8 on Windows 7.

Original comment by emily.hu...@state.ma.us on 17 Nov 2011 at 6:46

• Changed state: Verified