PiRSquared17 / morisoliver

Automatically exported from code.google.com/p/morisoliver
0 stars 0 forks source link

Increase size of identify box #39

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When a user identifies by clicking a single point on the map, we'd like to have 
a larger buffer around that single point when the tool looks for intersecting 
features. For example, if I click on the map over a point I want to identify, I 
sometimes get 0 features as the result (see attached screenshots). If I zoom, I 
notice that when I'm clicking a single point, the tool is actually drawing a 
small box. If that small box were slightly larger, then my single click may 
have a better chance of intersecting the point I want identified.

Original issue reported on code.google.com by emily.hu...@state.ma.us on 29 Jul 2011 at 3:22

Attachments:

GoogleCodeExporter commented 9 years ago
The size of the bbox has been increased for a point query.  See if this does 
the trick, especially on data that is close together.

Committed revision 75.

Original comment by cpl...@gmail.com on 24 Aug 2011 at 8:01

GoogleCodeExporter commented 9 years ago
I've commented-out my changes because it was breaking standard queries.

Original comment by cpl...@gmail.com on 25 Aug 2011 at 2:54

GoogleCodeExporter commented 9 years ago
Hopefully this is unbroken now.  I now check to see the size of the query in 
pixels.  If you are performing a bbox query and you manage to do what we know 
as a point query, it is a bbox of 8x8.  I check for this and ship out a bbox of 
4x4 to the query summary popup.  Similarly, for the query by poly, if you 
manage to do a point query, it is a whopping 0x0 query.  I soup this up to 8x8 
as well.

Both souped up bboxes are relative to the center of the original query.

I tested this w/ a point layer, and 8x8 seemed to do the trick.  But it's 
easily tweakable if you find that it includes or continues to exclude too much.

Committed revision 113.

Original comment by cpl...@gmail.com on 16 Sep 2011 at 6:38

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Bah.  The above explanation flipped the bboxes.

Point for bbox starts out as 2x2 or 0x0.  If the query comes in <= those then 
it is upped to 8x8.

Original comment by cpl...@gmail.com on 16 Sep 2011 at 6:40

GoogleCodeExporter commented 9 years ago
I tried to identify by single click on MIMIC sites points and I think it's 
better.  CZM, what do you think? 

Original comment by Aleda.Fr...@state.ma.us on 16 Sep 2011 at 8:11

GoogleCodeExporter commented 9 years ago
Yes, the single click works well now.

*****

New stuff:

When you select a feature, you see "1 found" under the "Feature(s) found" 
column in the "At a glance frame".  If you then click on the layer with the 
feature, the attribute pops into the Feature details frame.  That's cool.

There may be a problem though from the user perspective when you then click on 
another feature.  Regardless of whether or not a feature is found, the Feature 
details still retains the attribute from the previous identify.  You can clear 
the feature by clicking on the appropriate layer and repopulating the Feature 
details.  This may be confusing since you can have ID'd a feature but be seeing 
the attribute from a different location or even a different layer.

Suggestion:
Clear the Feature details each time the Identify tool is clicked on the map.  
That assures that the user is always looking at the most current feature detail.

Original comment by daniel.s...@state.ma.us on 23 Sep 2011 at 7:22

GoogleCodeExporter commented 9 years ago
Good call.

Committed revision 154.

(v. 0.52) (I'll try to do a better job of updating the v # under Help.)

Original comment by cpl...@gmail.com on 23 Sep 2011 at 7:42

GoogleCodeExporter commented 9 years ago
I agree with Aleda and Dan that the single click to identify works better now. 
The Feature details table is now being cleared each time the Identify tool is 
clicked on the map. Tested with Chrome 14 on Windows 7.

Original comment by emily.hu...@state.ma.us on 26 Sep 2011 at 3:12

GoogleCodeExporter commented 9 years ago
We just noticed that the feature details aren't being completely cleared when 
the identify tool is clicked on the map. When you first identify, the feature 
details portion of the query results window is blank. If you view the feature 
details of a layer, close the identify window, and do a new identify, then you 
will see the attribute field names for the last layer you identified in the 
feature details section. Same thing happens when you click on the map to do a 
new identify. In both cases, the feature details section of the identify window 
should completely clear and be blank like it is when you initially launch the 
identify tool.

Original comment by emily.hu...@state.ma.us on 30 Nov 2011 at 3:36

GoogleCodeExporter commented 9 years ago
I'm pretty wary about touching the query now that poly and bbox queries seem to 
be functioning properly, but I think I got away w/ this change w/o breaking 
anything.

v. 0.95
Committed revision 250.

Original comment by cpl...@gmail.com on 30 Nov 2011 at 3:54

GoogleCodeExporter commented 9 years ago
The feature details are now cleared after I close the identify window and do a 
new query, but we're still seeing the feature details when we click on the map 
to do a new query. For example, I identified on the default layers and viewed 
the feature details of the New England Mask. I then did a new query (without 
closing the query results window) that didn't intersect the New England Mask, 
but I still see the STATE_NAME field name for the New England Mask in the 
feature details table (see attached screenshot). Would it be possible to clear 
the field names or the feature details table when a user clicks on the map to 
do a new identify without closing the query results window?

We also have a bug where you can draw two identify polygons. Here are the steps:

1. Refresh MORIS.
2. Identify by poly and leave results window open.
3. Identify by poly again. Works well (i.e., old poly clears).
4. Close results window.
5. Identify by poly and leave results window open.
6. Identify by poly again. You should find two identify polys on the map (see 
attached screenshot).  If I leave the results window open and draw on the map 
again, the second poly clears, but the first poly stays. As so on if I continue 
drawing polys. They don't pile up; it's just the first poly that never goes 
away. To "fix" this you would have to refresh MORIS.  After a refresh, it works 
well the first time (Steps 1-3). Once the results window closes, subsequent 
queries yield the bug (Steps 4-6).

Original comment by emily.hu...@state.ma.us on 1 Dec 2011 at 1:56

Attachments:

GoogleCodeExporter commented 9 years ago
The query details are now being cleared when you finish drawing a bbox or a 
poly.

v. 0.96
Committed revision 253.

Original comment by cpl...@gmail.com on 2 Dec 2011 at 5:33

GoogleCodeExporter commented 9 years ago
Hi Charlton, yes the query details are now being cleared.
However, we still see the "two-poly problem". 

Original comment by Aleda.Fr...@state.ma.us on 2 Dec 2011 at 7:33

GoogleCodeExporter commented 9 years ago
Sorry, I didn't see that part of the issue.  My mistake.

The system seems a bit unhappy, so I can't guarantee that the queries are 
working, but the polygon seems to be erasing properly now.

v. 1.00
Committed revision 259.

Original comment by cpl...@gmail.com on 2 Dec 2011 at 9:01

GoogleCodeExporter commented 9 years ago
Looks good! The leftover poly is now being cleared. Verified.

Original comment by emily.hu...@state.ma.us on 6 Dec 2011 at 3:40