Problem playing demos/recordings when started with "-113" commandline option

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Start Quadra with the "-113" command-line option.
2. Play a singleplayer game.
3. After the game is finished, immediately try to play the corresponding
demo (REC/QREC file).

What is the expected output? What do you see instead?
The expected output is that the demo/recording should be played. Instead,
the demo/recording does not play at all.

What version of the product are you using? On what operating system?
Quadra 1.1.8 with floating next pieces patched in on Windows XP.

Please provide any additional information below.
1) A workaround for this bug is to exit completely and start Quadra without
the "-113" command-line option. The demo/recording can now be played.

2) Recordings from version 1.1.3 of Quadra can be played when Quadra v1.1.8
is started with the "-113" command-line option.

3) This is entirely speculation on my part... I suspect that the "-113"
commandline option tricks Quadra into thinking that it *IS* Quadra v1.1.3
rather than only using the scoring system from v1.1.3.
[Note that the REC file was labelled correctly (i.e., as played under
Quadra v1.1.8 when I used the aforementioned workaround).]

Original issue reported on code.google.com by bgch...@gmail.com on 14 Mar 2008 at 6:29

[GoogleCodeExporter]

Single-player games recorded while under the effect of the -113 option are 
incorrectly marked as net_version 22 (should be 20) because 
Game_params::set_preset 
set both attack types to ATTACK_NONE in the PRESET_SINGLE and 
PRESET_SINGLE_SPRINT 
cases. Those 4 lines should simply be removed (leaving the attack type to the 
default ATTACK_LINES). Since there's no one to attack, I can't foresee any ill 
effect.

I should probably set up a build environment and fix it myself... In the 
meantime, 
assigning to pphaneuf.

Original comment by slaj...@gmail.com on 18 Mar 2008 at 9:25

• Changed state: Accepted

[GoogleCodeExporter]

I'm set up to build now, taking this back.

Original comment by slaj...@gmail.com on 18 Mar 2008 at 11:46

[GoogleCodeExporter]

Fixed.

Original comment by slaj...@gmail.com on 18 Mar 2008 at 11:52

• Changed state: Verified

[GoogleCodeExporter]

RZ***Brandon added:

Displaying less than 5 high scores happens when the *.rec file is unable to be 
read
by Quadra. For example, any *.rec files recorded by Quadra v1.1.8 cannot be 
played in
Quadra v1.1.3. The two cheated scores had corresponding *.rec files that the 
version
of Quadra that you were running could not understand -- and so those files were
skipped when showing Global High Scores. You can encounter the same issue in 
Local
High Scores by moving your local0, local1, ...local 4 REC files to a Quadra 
v1.1.3's
directory and running Quadra v1.1.3. (I think this occurs with 1.1.8 and 1.1.5 
also.)

Original comment by pphaneuf on 19 Mar 2008 at 2:11

• Changed state: Fixed

[GoogleCodeExporter]

This is all true but cannot be remedied short of building a time machine to 
make 
those old versions understand newer game rules. Workaround: only use the most 
recent 
version.

Original comment by slaj...@gmail.com on 19 Mar 2008 at 3:59

• Changed state: Verified

[GoogleCodeExporter]

Yes, I agree. Such a fix is unreasonable for the reason you have pointed out. So
personally, I purposely did not report the issue. :)

I suppose one could argue that Quadra v1.2.0 should be able to play Quadra 
v1.3.0
recorded files (assuming that the Game Type is one that is recognized). 
However, then
it would be difficult to ever change scoring system from that used in 1.2.0. So 
even
that is not a good idea. In short, everyone should "only use the most recent 
version"
at all times, especially now that -113 is fixed in the next version! ;)

Original comment by bgch...@gmail.com on 21 Mar 2008 at 6:27

[GoogleCodeExporter]

Adding to what bgching just said, I think it's perfectly reasonable to make 
replays
only playable in the version that created them. Many things could change from 
one
version to the next, and backwards compatibility may just be too much of a 
hassle,
especially if you have to be able to play demos from multiple versions...

Original comment by Shrapnel.City@gmail.com on 21 Mar 2008 at 8:43