PiRSquared17 / redmine-dmsf

Automatically exported from code.google.com/p/redmine-dmsf
0 stars 0 forks source link

File name lost when uploading a revision #174

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
1. Add an xls document 
2. Create a revision for a pdf document
3. The revision is stored as an xls document

Usually, I create xls (excel document), and before sending it to a customer, I 
transform it to a PDF (or I print, sign, and scan as PDF).

I'd like to have the xls version as version 0.1, and when signed and sent to 
customer, add a revision as a PDF (version 1.0).
This way, if I'd have to edit again, I can go in the revision history to see 
the xls version.

But as it is now, when I try to upload the revision, it is uploaded (the file 
size if the size of the PDF), but the name of the files rename the name of the 
xls file and I cannot change it.

I did a quick test. Copy of FileName.xls to FileName_2.xls. Modify it slightly. 
Create a revision of FileName.xls, with new contents FileName_2.xls, and new 
title.

The title of the revision is changed. But the name of the file doesn't, it 
remains FileName.xls.

If I try to download both revision, they do have the same file name, but the 
content is indeed modified (so the new revision doesn't overwrite the old even 
if the files have the same name).

This need to be fixed: the file name should remain as it is when we upload it. 
When I download a revision, I want to have the same name as when I upload it. 
We include the date or the version number in the the file name, I don't want it 
to be reset to 0.1 everytime!

Original issue reported on code.google.com by da...@aeroinsys.com on 25 Oct 2011 at 9:00

GoogleCodeExporter commented 9 years ago
This is not a bug, it is intentional. You can manualy rename file when 
uploading new revision. The key thing is that it is expected many users could 
access document and changing filename could cause troubles to match local 
copies. So manual renaming is required to approve intention.

Original comment by vit.jo...@gmail.com on 25 Oct 2011 at 11:01

GoogleCodeExporter commented 9 years ago
Summary of email with detailed and screenshots

I understand that you want the name to be changed explicitly, but perhaps you 
can improve it:
1)  Keeping the file name why not. But could you at least consider updating the 
file extension? If I upload a PDF, the default would be to get a PDF when I 
download. As it is now, it remains an XLS if it’s an XLS I uploaded first. 
Meaning that if I’m not very careful, I won’t be able to open my file 
anymore after I download it, and I may think it has been corrupted. Can you by 
default keep the name, but change the extension?
2)  Can you add a button somewhere with “Update name to match new content” 
or something like that? 
3)  Or add a check box, checked by default, with “Keep file name”?

This way, by default the name is kept, but if the user explicitly uncheck 
“Keep file name”, then it would use the name of the New Content instead, or 
with the button solution, by default it keeps the name, or the user can 
manually edit the name to whatever he likes, or if he click on the button, he 
get the correct new name and extension? It doesn’t seem much, but believe me, 
I tried the manual edit solution, and with long file path / file name and short 
editbox, it’s not easy to be sure you copied it right! And anyway, manual 
copy should be avoided as much as possible to limit human error.

Original comment by da...@aeroinsys.com on 25 Oct 2011 at 11:44

GoogleCodeExporter commented 9 years ago
OK. I will try to improve behavior based on previous suggestions

Original comment by vit.jo...@gmail.com on 25 Oct 2011 at 9:13