PiRSquared17 / wikiwym

Automatically exported from code.google.com/p/wikiwym
0 stars 0 forks source link

Links that starts with the hash #17

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
GoCoWiki allows me to have this:

[#Introducing_Nest.js Introducing Nest.js]

However your implementation doesn't allow it because of:
line 538:   else if( ! /[a-zA-Z]/.test(text.charAt(i+1)) ) {

so the easiest fix would be:

else if( ! /[#a-zA-Z]/.test(text.charAt(i+1)) ) {

But I believe that this will require some more testing / investigation.

Btw how can I participate in your project? I'm very interested :)

Original issue reported on code.google.com by matveev....@gmail.com on 1 Apr 2011 at 9:14

GoogleCodeExporter commented 9 years ago
Sorry for the delay - i don't get sent the bug reports by default :/.

Good catch. i recently added '/' as a legal start character and will add this 
to the trunk today.

Original comment by sgbeal@googlemail.com on 27 Apr 2011 at 4:09

GoogleCodeExporter commented 9 years ago

Original comment by sgbeal@googlemail.com on 27 Apr 2011 at 4:09

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r215.

Original comment by sgbeal@googlemail.com on 27 Apr 2011 at 4:13

GoogleCodeExporter commented 9 years ago
It's fixed in r215. It's currently in the trunk and i'll move it to the 
"stable" branch (the one we like people to use when including the code directly 
from GoCo) the next time i update that branch. Until then, please pull the 
trunk version, which has some recent spacing-related fixes and tweaks.

Thanks for taking the time to report the problem!

Original comment by sgbeal@googlemail.com on 27 Apr 2011 at 4:14

GoogleCodeExporter commented 9 years ago
Thank you!

Original comment by matveev....@gmail.com on 27 Apr 2011 at 4:15

GoogleCodeExporter commented 9 years ago
i can't miss this opportunity for a shameless plug:

i'm now using wikiwym extensively on this site:

http://fossil.wanderinghorse.net/demos/whiki/

and if you're interested in how to customize the output of the wiki-generated 
links so that they can work in a "live" application, see that page's source and 
search for "WhikiApp.createGoCoLink". That is a replacement for 
GoogleWikiCodeParser.createLink(), customized for that particular application.

Original comment by sgbeal@googlemail.com on 27 Apr 2011 at 4:30

GoogleCodeExporter commented 9 years ago
One more thing: in your opinion should we also add '?' as a legal start 
character? e.g. [?param1=a¶m2=b run query]

:-?

Original comment by sgbeal@googlemail.com on 27 Apr 2011 at 4:31

GoogleCodeExporter commented 9 years ago
Same for me :P
I've even made a blog post about it:

http://angrycoding.blogspot.com/2011/04/recreating-google-code-wiki-with.html

And about "?" I think that is reasonable to add that, I can think of the 
situation where this might be very useful.

One more thing that might be really cool is to provide some kind of "callback" 
mechanism, to pro / pre process some things. Like for example call syntax 
highlighter when {{{ ... }}} has been found, and so on.

Original comment by matveev....@gmail.com on 27 Apr 2011 at 4:35

GoogleCodeExporter commented 9 years ago
Thanks for the blog post! i'll get that links in on the site somewhere.

Callbacks would be a really nice feature. i've considered rewriting it to 
generate an object tree, instead of HTML, which would probably obviate (or 
lessen) the need for callbacks.

i don't know off the top of my head if i could shoehorn callbacks in to the 
current code, but i really like the idea and worst-case i will delay that until 
i re-implement the parser (which isn't on the immediate todo list, but someday 
i'm likely to get inspired to do it).

Regarding this bit:

// this is necessary in order to keep line breaks in <pre /> and <code /> tags
wikiParser.options.outputSeparator = '\n';

i fixed that last weekend sometime. The outputSeparator should always be \n or 
it breaks several other bits. i can't believe i didn't see the problem for such 
a long time, though.

Original comment by sgbeal@googlemail.com on 27 Apr 2011 at 4:51

GoogleCodeExporter commented 9 years ago
nice, glad to hear that the project is active. What kind of parsing technique 
are you considering to use?

Original comment by matveev....@gmail.com on 27 Apr 2011 at 5:04