PiRSquared17 / zkgrails

Automatically exported from code.google.com/p/zkgrails
0 stars 0 forks source link

Listbox multiple selection is not working anymore. RadioButtons are rendered instead of Checkboxes #327

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Which version of ZKGrails you're using? On what operating system?
2.2.0 (Windows XP, OSX 10.8.1, Windows 2008 Server R2)

Which version of Grails you're using?
2.2.1

What steps will reproduce the problem?
1. Uncompress example
2. open http://localhost:8080/multiSelectListboxBug/testmslistbox.zul in browser

What is the expected output? What do you see instead?
No radio buttons, checkboxes should be rendered in the list and multiple 
selection should be working again.

Please provide any additional information below. Attaching a test case to
reproduce it is preferable.
For example grails app please see the attachment.

Please fix this issue. This is a showstopper for us. We are currently updating 
our grails app from zk-1.0.6 to zk-2.x.

Thank you very much.

Regards,
Alex

Original issue reported on code.google.com by alex.fre...@gmail.com on 12 Jun 2013 at 5:07

Attachments:

GoogleCodeExporter commented 9 years ago
Thank you for reporting. I'll have a look.

Original comment by chanwit on 12 Jun 2013 at 5:29

GoogleCodeExporter commented 9 years ago
Fixed by commit: 1029f29573d624e78c1ebc35f22fe0896d6c3823

A new `setModel` method is added to help this compatibility issue in zk-2.2.3. 
It also calls .invalidate() after setting the model.

Here's how to use:

{{{
class Issue327Composer extends zk.grails.Composer {

    def afterCompose = { wnd ->
        def model = []
        (1..50).each { i ->
            model << "${i}"
        }
        $('#testListbox').model = new ListModelList(model)
    }

}
}}}

Original comment by chanwit on 13 Jun 2013 at 9:27

GoogleCodeExporter commented 9 years ago
Chanwit,

Thank you for this fast fix.  

How can I access the source code to do the patching myself? Do I need to have 
access to LTS? The svn gives me an error and the github repo is not up to date 
as it seems.

Do you plan on patching this fix to 2.2.0 -> 2.2.1? I ask because we don't have 
access to the LTS and I really would like to get this working as soon as 
possible.

Thank you very much.

Regards,
Alex

Original comment by alex.fre...@gmail.com on 13 Jun 2013 at 10:58

GoogleCodeExporter commented 9 years ago
Hi Alex,

It will be released into LTS this evening my time in v2.2.3. So yes, you 
require an LTS subscription for accessing to the latest version.

But if you do not want to subscribe, this change will also be included into the 
next public (2.3.0) release by the end of August.

Thanks

Chanwit

Original comment by chanwit on 14 Jun 2013 at 4:50

GoogleCodeExporter commented 9 years ago
Version 2.2.4 fixes this issue _without_ the need to change the code to 
$('#testListbox').model = new ListModelList(model). The usual testListbox.model 
= new ListModelList(model) is good enough.

Thank you Chanwit for the quick fix.

Regards,
Alex 

Original comment by alex.fre...@gmail.com on 28 Jun 2013 at 7:39