search

PiRogueToolSuite / pirogue-os

OS image for the PiRogue based on Debian 12
https://pts-project.org/
154 stars 6 forks source link

Download failures are ignored #6

Open CyrilBrulebois opened 2 years ago

CyrilBrulebois commented 2 years ago

With a local build attempt, at armv7_v1.0.0_rc.6, I've just gotten:

Err:168 https://piroguetoolsuite.github.io/ppa/pirogue-3rd-party ./ influxdb 1.8.10-1
  Connection failed [IP: 2606:50c0:8001::153 443]
…
E: Failed to fetch https://piroguetoolsuite.github.io/ppa/pirogue-3rd-party/./influxdb_1.8.10-1_armhf.deb  Connection failed [IP: 2606:50c0:8001::153 443]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
[13:23:33] End /home/kibi/work/clients/pirogue/pirogue-os/stage2/04-pirogue/01-run.sh
[13:23:33] End /home/kibi/work/clients/pirogue/pirogue-os/stage2/04-pirogue
[13:23:33] End /home/kibi/work/clients/pirogue/pirogue-os/stage2
[13:23:33] Begin /home/kibi/work/clients/pirogue/pirogue-os/stage3
[13:23:33] End /home/kibi/work/clients/pirogue/pirogue-os/stage3
[13:23:33] Begin /home/kibi/work/clients/pirogue/pirogue-os/stage4
[13:23:33] End /home/kibi/work/clients/pirogue/pirogue-os/stage4
[13:23:33] Begin /home/kibi/work/clients/pirogue/pirogue-os/stage5
[13:23:33] End /home/kibi/work/clients/pirogue/pirogue-os/stage5
[13:23:33] Begin /home/kibi/work/clients/pirogue/pirogue-os/export-image
[13:23:33] Begin /home/kibi/work/clients/pirogue/pirogue-os/export-image/prerun.sh

which means the whole set of pirogue packages wasn't installed, and yet the build kept on going.

This is brittle and means we could be building images successfully… without the actual pirogue tooling.

It might be due to the way commands are run within the chroot (not failing the caller when they fail); or it might be something else with the way scripts are called by the pi building tool. The script itself (stage2/04-pirogue/01-run.sh) is set -e at least…