search

PiSCSI / piscsi

PiSCSI allows a Raspberry Pi to function as emulated SCSI devices (hard disk, CD-ROM, and others) for vintage SCSI-based computers and devices. This is a fork of the RaSCSI project by GIMONS.
https://piscsi.org
BSD 3-Clause "New" or "Revised" License
535 stars 82 forks source link

Buster deprecation: easyinstall.sh #1195

Closed rdmark closed 11 months ago

rdmark commented 1 year ago

This ticket is to track modifications to easyinstall.sh required for the Buster deprecation

rdmark commented 1 year ago

At this moment I have identified one required update: The removal of the locking of clang to v11. This was required on Buster since it shipped with a too old version of clang (v7) as the default, and we had to specifically use the v11 package.

On Bullseye, v11 is the default, and on Bookwork the default is v14 which has no issues with our codebase in my testing.

PR that removes the locking to v11 and defaults to the distro default https://github.com/PiSCSI/piscsi/pull/1194

uweseimet commented 1 year ago

@rdmark Please take notice of my changes to easyinstall in the issue_1179 branch. What about adding any required changes to easyinstall to this branch?

One more thing: I don't think anything related to deprecating buster should be merged before there are official bookworm images for the Pi, which will most likely still take several weeks.

rdmark commented 1 year ago

@uweseimet Normally I prefer to make smaller stand-alone changes in separate PRs. But since you already have changes in your branch I can discard my branch.

BTW, what do you think about locking to a newer version (such as clang-13 in your branch) vs. letting it float with the default for the distro (as in my branch)? I can see pros and cons, but my choice would be to let it float since it removes the maintenance overhead of managing the package and compiler version.

uweseimet commented 1 year ago

@rdmark If the default compiler works fine I agree that there is no need for using a newer version, unless it turns out that there is an issue with the old compiler. In case you test with the default compiler, can you please also test whether the -flto option produces correctly working binares?

rdmark commented 1 year ago

@uweseimet I tested Raspbian bullseye default clang (11.0.1-2+rpi1) with -flto using your work branch. The resulting piscsi and scsictl binaries seem to work well, although I did only cursory dynamic testing.

I'll test on Raspbian bookworm once it's released.

uweseimet commented 11 months ago

@rdmark Is there still anything to be done for this ticket, or can we close it?

rdmark commented 11 months ago

Nothing else that I can think of.