search

PiSCSI / piscsi

PiSCSI allows a Raspberry Pi to function as emulated SCSI devices (hard disk, CD-ROM, and others) for vintage SCSI-based computers and devices. This is a fork of the RaSCSI project by GIMONS.
https://piscsi.org
BSD 3-Clause "New" or "Revised" License
545 stars 82 forks source link

Aibom and Gamernium code got removed with the bananapi cleanup #1315

Closed rdmark closed 1 year ago

rdmark commented 1 year ago

The bananapi cleanup seems to have inadvertently removed some of the code that builds and manages connections with Aibom and Gamernium rascsi board types.

These are board types that has an install base and it's valuable for piscsi to support these, in my opinion.

The commit that removed code: https://github.com/PiSCSI/piscsi/commit/43088ab3bcfef07ea891437755a82a1e41c7a0e4

uweseimet commented 1 year ago

I see. I thought this code was related to the Banana Pi. I am going to re-add it.

uweseimet commented 1 year ago

@rdmark Looking closer at this code it actually IS related to the Banana Pi. It relies on files required for the Banana Pi:

#include "hal/pi_defs/bpi-m2p.h"
#include <string>

bpi-mp2.h says:

Copyright (c) 2014-2017 Banana Pi
rdmark commented 1 year ago

@uweseimet That header is only needed for bananapi related symbols. So connection_gamernium.h and connection_aibom.h need to be restored, but with the bananapi lines removed. Like you did for connection_fullspec.h for instance.

uweseimet commented 1 year ago

@rdmark OK, thank you for spotting this.