PiSCSI / piscsi

PiSCSI allows a Raspberry Pi to function as emulated SCSI devices (hard disk, CD-ROM, and others) for vintage SCSI-based computers and devices. This is a fork of the RaSCSI project by GIMONS.
https://piscsi.org
BSD 3-Clause "New" or "Revised" License
545 stars 82 forks source link

Small typo in easyinstall.sh menu #1371

Closed fdanapfel closed 1 year ago

fdanapfel commented 1 year ago

Info

Describe the issue

The menu items in easyinstall.sh are numbered from 1 to 17, but on the line to choose which menu item it says "(0-17)":

pi@rascsi:~/piscsi $ ./easyinstall.sh 
    .~~.   .~~.
   '. \ ' ' / .'
    .╔═══════╗.
   : ║|¯¯¯¯¯|║ :
  ~ (║|_____|║) ~
 ( : ║ .  __ ║ : )
  ~ .╚╦═════╦╝. ~
   (  ¯¯¯¯¯¯¯  ) PiSCSI Assistant
    '~ .~~~. ~'
        '~'

Board Type: FULLSPEC | Compiler: clang++ | Compiler Cores: 1

Choose among the following options:
INSTALL/UPDATE PISCSI
  1) Install or update PiSCSI Service + Web Interface
  2) Install or update PiSCSI Service
  3) Install or update PiSCSI OLED Screen (requires hardware)
  4) Install or update PiSCSI Control Board UI (requires hardware)
NETWORK BRIDGE ASSISTANT
  5) Configure network bridge for Ethernet (DHCP)
  6) Configure network bridge for WiFi (static IP + NAT)
INSTALL COMPANION APPS
  7) Install AppleShare File Server (Netatalk)
  8) Install FTP File Server (vsftpd)
  9) Install SMB File Server (Samba)
 10) Install Web Proxy Server (Macproxy)
ADVANCED OPTIONS
 11) Compile and install PiSCSI stand-alone
 12) Configure the PiSCSI Web Interface stand-alone
 13) Enable or disable PiSCSI back-end authentication
 14) Enable or disable PiSCSI Web Interface authentication
EXPERIMENTAL FEATURES
 15) Share the images dir over AppleShare (requires Netatalk)
 16) Compile PiSCSI binaries
 17) Install Webmin to manage Netatalk and Samba
Enter your choice (0-17) or CTRL-C to exit:  

It should say "Enter your choice (1-17)".

uweseimet commented 1 year ago

@fdanapfel Would you like to create a PR yourself, against the develop branch? If not it's fine, you would have to create a fork first I think.

fdanapfel commented 1 year ago

@uweseimet My github skills are a bit rusty, therefore I'll leave it up to the experts to create a PR with a fix for this.