Multiple fixes for ModeSelect

PiSCSI / piscsi

PiSCSI allows a Raspberry Pi to function as emulated SCSI devices (hard disk, CD-ROM, and others) for vintage SCSI-based computers and devices. This is a fork of the RaSCSI project by GIMONS.

https://piscsi.org

BSD 3-Clause "New" or "Revised" License

545 stars 82 forks source link

Multiple fixes for ModeSelect #1405

Closed kkaempf closed 10 months ago

kkaempf commented 11 months ago

This PR covers multiple issues

The DEC Alpha SRM console (aka BIOS) calls ModeSelect6 with no payload
OpenVMS Alpha calls ModeSelect6 with a page code of 1
ModeSelect had an off-by-one error in computing the length

Fixes #1402

kkaempf commented 11 months ago

@rdmark frankly, I'm at loss with fixing the tests :-( Is there any documentation ?

rdmark commented 11 months ago

@kkaempf The closest we have to documentation is the issue ticket where the tests were initially introduced! https://github.com/PiSCSI/piscsi/issues/794

Running the tests should be as easy as installing the googletest libraries, and then running make test. You can also see the failing CI jobs here in this PR.

The actual test code should be fairly self-explanatory I think, but let me know if you need further pointers ;)

kkaempf commented 10 months ago

The test output is quite unhelpful 😞

[ RUN      ] ScsiCommandUtilTest.ModeSelect6
unknown file: Failure
C++ exception with description "std::exception" thrown in the test body.
[  FAILED  ] ScsiCommandUtilTest.ModeSelect6 (0 ms)

kkaempf commented 10 months ago

Tests fixed (somewhat hackish imho)

rdmark commented 10 months ago

@kkaempf What makes you say the tests are hackish?

kkaempf commented 10 months ago