search

PiSCSI / piscsi

PiSCSI allows a Raspberry Pi to function as emulated SCSI devices (hard disk, CD-ROM, and others) for vintage SCSI-based computers and devices. This is a fork of the RaSCSI project by GIMONS.
https://piscsi.org
BSD 3-Clause "New" or "Revised" License
545 stars 82 forks source link

Add ModeSense page 0x25 (DEC special function control page) #1412

Closed kkaempf closed 10 months ago

kkaempf commented 10 months ago

VAXServer 3100 (CPU KA41-E) console firmware issues ModeSense(6) page 0x25 when probing for disks. A disk won't be recognized if this returns an error.

The DEC SCSI specification[1], section 8.5 documents this page.

[1] https://manx-docs.org/collections/antonio/dec/dec-scsi.pdf

Fixes #1410

rdmark commented 10 months ago

@kkaempf Please rebase your branch with develop now so that we can confirm that this code passes in the updated CI pipeline. :)

kkaempf commented 10 months ago

@kkaempf Please rebase your branch with develop now so that we can confirm that this code passes in the updated CI pipeline. :)

Done. Tests still pass for me 🤞🏻

sonarcloud[bot] commented 10 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

rdmark commented 10 months ago

@kkaempf Yay! Thanks for working through that issue.

May I ask you to respond to my earlier code review question? It might be my misunderstanding the code, but I would like to get clarity before merging.

kkaempf commented 10 months ago

Sorry, hadn't realize that there was an outstanding question. Answered now.