search

PiSCSI / piscsi

PiSCSI allows a Raspberry Pi to function as emulated SCSI devices (hard disk, CD-ROM, and others) for vintage SCSI-based computers and devices. This is a fork of the RaSCSI project by GIMONS.
https://piscsi.org
BSD 3-Clause "New" or "Revised" License
545 stars 82 forks source link

Unit test assertions failure in ScsiCdTest_ModeSelect_Test::TestBody #1418

Closed rdmark closed 10 months ago

rdmark commented 10 months ago

When run in debug mode, there is an assertion failure in ScsiCdTest_ModeSelect_Test::TestBody. This is only triggered when unit tests are compiled with the DEBUG=1 flag.

Uwe spotted and reported this in https://github.com/PiSCSI/piscsi/issues/1415 -- see that ticket for the stack trace with symbols.

rdmark commented 10 months ago

@kkaempf I think this failed assertion was introduced with https://github.com/PiSCSI/piscsi/pull/1406

Would you be able to have a look?

FWIW I'm proposing we enable DEBUG for unit tests in the CI workflow as well, to catch these earlier in the future: https://github.com/PiSCSI/piscsi/pull/1417

kkaempf commented 10 months ago

I can't reproduce a test crash on my issue-1410 branch (forked from ad5eae93e) when compiled with DEBUG=1 🤷🏻‍♂️

kkaempf commented 10 months ago

I'll rebase and test again ...

kkaempf commented 10 months ago

Rebased onto 7a986c84aa54fa550e1255f5ff83174b294fa3f4 I get a crash