Update Makefile to use clang++

PiSCSI / piscsi

PiSCSI allows a Raspberry Pi to function as emulated SCSI devices (hard disk, CD-ROM, and others) for vintage SCSI-based computers and devices. This is a fork of the RaSCSI project by GIMONS.

https://piscsi.org

BSD 3-Clause "New" or "Revised" License

539 stars 82 forks source link

Update Makefile to use clang++ #972

Closed akuker closed 1 year ago

akuker commented 1 year ago

easyinstall.sh has been updated in PR #971 to install clang++. The Makefile should be updated to use clang by default instead of gcc.

Note: I don't think there is any need to go back to gcc, so I think it can be a one-way change.

Ideally, the makefile will still allow for cross-compilation on a x86 system for the ARM platform.

uweseimet commented 1 year ago

Please see my comment regarding code metrics in https://github.com/akuker/RASCSI/issues/968. Before updating the Makeifile pleease ensure that everything else is still functional. It would be bad to have no code coverage metrics and/or code analysis anymore.

uweseimet commented 1 year ago

Is this ticket still needed? Changing the Makefile is not recommended because:

With clang++ there are issues with getting the code metrics
g++ is the default compiler for the Pi, so it should also be our Makefile default
The compiler switch in easyinstall appears to work fine, so there is no reason to change anything