search

PiSupply / PaPiRus

Resources for PaPiRus ePaper eInk displays
https://www.pi-supply.com/product/papirus-epaper-eink-screen-hat-for-raspberry-pi/
Other
346 stars 88 forks source link

Update to read scale operation #125

Closed stephen-kobe closed 7 years ago

stephen-kobe commented 7 years ago

It’s just a correction to display at the correct scale.

shawaj commented 7 years ago

this is in relation to issue #60

@sKoeberle there is a conflict with the file you sent - can you resolve it?

shawaj commented 7 years ago

also @sKoeberle can you give us a bit of info as to what the purpose of this change is, and how it would be used? so we can update readme

francesco-vannini commented 7 years ago

Hi @sKoeberle, when did you branch out the code? You are not working on the latest version of papirus-temp it seems to me

shawaj commented 7 years ago

@sKoeberle it seems since your latest commit, there is actually no changes to the existing files? Perhaps as said by @francesco-vannini you can get rid of your fork and then start the changes from a clean one, or squash these commits so there is only a single one. Right now it is too messy and taking too much time to look through what you are trying to achieve.

also @sKoeberle did you see my message above?

"Can you give us a bit of info as to what the purpose of this change is, and how it would be used? so we can update readme?"

stephen-kobe commented 7 years ago

It’s just a little correction to display characters at the correct scale when scale is indicated as here: "scale=3". Without this modification, changing the scale hasn't any effects on display.

francesco-vannini commented 7 years ago

Hi, really appreciate your help here but the file had already been changed to that, please have a look at it in the current version https://github.com/PiSupply/PaPiRus/blob/master/bin/papirus-temp

francesco-vannini commented 7 years ago

@sKoeberle I'll close this. By all means I am happy to reopen this again if I didn't understand what you were getting at.