search

PiSupply / PaPiRus

Resources for PaPiRus ePaper eInk displays
https://www.pi-supply.com/product/papirus-epaper-eink-screen-hat-for-raspberry-pi/
Other
346 stars 88 forks source link

Remove test code from papirus-draw #149

Closed GekoPrime closed 6 years ago

GekoPrime commented 6 years ago

papirus-draw now draws the image only once.

Previously the image was drawn five times: once at each rotation, and finally at the requested rotation

tvoverbeek commented 6 years ago

It is intended as demo code to show the effects of all rotation angles, hence the five times. Before the rotation argument was added we had the single draw image (as in your PR).

shawaj commented 6 years ago

@tvoverbeek papirus draw was originally intended to be a "functional" bit of code to allow people to put images on screen from command line.

Is that not the case anymore?

In readme it has:

# Draw image on the screen
papirus-draw /path/to/image -t [resize | crop] -r [0 | 90 | 180 | 270]
tvoverbeek commented 6 years ago

@shawaj OK, I accept the "functional" part and will merge this.

shawaj commented 6 years ago

Awesome, thanks @tvoverbeek - maybe we can have a papirus-draw-demo or something showing the 5 times?

On Thu, Aug 24, 2017 at 7:23 PM, Ton van Overbeek notifications@github.com wrote:

Merged #149 https://github.com/PiSupply/PaPiRus/pull/149.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PiSupply/PaPiRus/pull/149#event-1220250349, or mute the thread https://github.com/notifications/unsubscribe-auth/ADNCus-4f6H702zRN7vRhRcSsIMWGSd2ks5sbb-pgaJpZM4O_baY .