PiSupply / PaPiRus

Resources for PaPiRus ePaper eInk displays
https://www.pi-supply.com/product/papirus-epaper-eink-screen-hat-for-raspberry-pi/
Other
346 stars 88 forks source link

update missing dependencies #151

Closed erickeller closed 6 years ago

erickeller commented 6 years ago

make and gcc is required for building some code at installation time.

shawaj commented 6 years ago

What system have you seen an error on? On Raspbian it seems to build just fine

tvoverbeek commented 6 years ago

Both Raspbian-full and Raspbian-lite already have make, gcc and whiptail installed. So no need to add them to the dependencies, unless you are running on some other OS

erickeller commented 6 years ago

On a raspbian wheey updated as Jessie... I think this dependencies are required especially when you use a small headless raspberry pi installation.

I think it's good practice to specify all dependencies apt will sort that out when the package is already installed.

Cheers

On Fri, Sep 8, 2017, 15:27 Aaron Shaw notifications@github.com wrote:

What system have you seen an error on? On Raspbian it seems to build just fine

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PiSupply/PaPiRus/pull/151#issuecomment-328102961, or mute the thread https://github.com/notifications/unsubscribe-auth/ABOw0vbMrvIknikuf7j4RnVa79bIexUFks5sgUC8gaJpZM4PRKIK .

shawaj commented 6 years ago

@erickeller yeah agreed there's no harm in adding them in

erickeller commented 6 years ago

if there are other dependencies please also add them into. what would also be nice to have is one file containing the dependencies (single source of truth) you include in your readme but for this I thin you need to move to the rst format.

Even better would be to move to a debian package :) Anyway I was able to use my nice papirus e-ink afterall, thanks for the good work.

shawaj commented 6 years ago

@tvoverbeek @francesco-vannini what do we think to this?

tvoverbeek commented 6 years ago

My original problem was that every call to apt-get scans the package database which takes time. Therefore I was sceptic to add additional apt-get calls. However combining aa many as possible required packages in a single apt-get call scans the database only once. Therefore no problem any more and merged

shawaj commented 6 years ago

Perfect!