PiSupply / PaPiRus

Resources for PaPiRus ePaper eInk displays
https://www.pi-supply.com/product/papirus-epaper-eink-screen-hat-for-raspberry-pi/
Other
346 stars 88 forks source link

Minor typo and wording fixes in README #178

Closed VirtualWolf closed 6 years ago

VirtualWolf commented 6 years ago

Just some very tiny fixes.

shawaj commented 6 years ago

Thanks! Mostly look ok but line 339 and 340 doesn't look complete?

shawaj commented 6 years ago

Also noticed that PaPiRus is capitalised incorrectly in a few places...

VirtualWolf commented 6 years ago

Thanks! Mostly look ok but line 339 and 340 doesn't look complete?

Hm, yeah, it could be improved... I assume the library will always just show the images in filename order, right? And it's just if you have an animation you need to name them in some sort of sequence where they'll be read in the right order (be it 0.gif, 1.gif, 2.gif or a.gif, b.gif, c.gif)?

Also noticed that PaPiRus is capitalised incorrectly in a few places...

Ah, good catch. It was tricky picking them out in between the places in the code examples where it's meant to be just "Paprius", heh.

shawaj commented 6 years ago

Yeah I'll correct those later.

About the mine 339 and 340 it was more that there was some text removed that shouldn't have been.

Just wondered if this was intentional and if so, then why?

francesco-vannini commented 6 years ago

PaPiRus animation can also be used as a slide show without any specific order for the pictures and with a few more picture formats allowed. The original description can be found in c93ecce374388e4352867ad8a7e384a4334e5b7e

 # Display image sequences or slide-show
 +The path containing the pictures must have number sequenced images in the form 1.gif, 2.gif, 3.gif, etc. for an animation or pictures with random names (e.g. in the case of a slide-show). 
  papirus-animation path [rotation] [delay] [fullupdate] [loop]
VirtualWolf commented 6 years ago

Just wondered if this was intentional and if so, then why?

Trying to make things a bit less wordy and clearer. :) I've updated it again, and fixed the Paprirus -> PaPiRus as well.

tvoverbeek commented 6 years ago

@VirtualWolf Thanks for the corrections. Apologies for the delay in merging.

VirtualWolf commented 6 years ago

No worries, cheers!