search

PiSupply / PaPiRus

Resources for PaPiRus ePaper eInk displays
https://www.pi-supply.com/product/papirus-epaper-eink-screen-hat-for-raspberry-pi/
Other
346 stars 88 forks source link

PaPiRus Positional Text #68

Closed BenScarb closed 7 years ago

BenScarb commented 7 years ago

Simple class for doing positional text on the PaPiRus screen.

shawaj commented 7 years ago

Just out of interest, does this allow for line breaks also?

BenScarb commented 7 years ago

No, currently the code doesn't take line breaks in to account. I'll take a look at that next.

shawaj commented 7 years ago

Awesome :-)

On 4 Jan 2017 6:04 am, "Ben" notifications@github.com wrote:

No, currently the code doesn't take line breaks in to account. I'll take a look at that next.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PiSupply/PaPiRus/pull/68#issuecomment-270300920, or mute the thread https://github.com/notifications/unsubscribe-auth/ADNCugd9NnBtjXpErPnzazsAhB-HpqOSks5rOzZxgaJpZM4LYivZ .

BenScarb commented 7 years ago

There we go, \n line breaks now supported :)

shawaj commented 7 years ago

Awesome. Do you think /r breaks are useful at all? Looks fantastic though.

On 4 Jan 2017 10:06 pm, "Ben" notifications@github.com wrote:

There we go, \n line breaks now supported :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PiSupply/PaPiRus/pull/68#issuecomment-270500594, or mute the thread https://github.com/notifications/unsubscribe-auth/ADNCumEjvhdfYuWb112X-c5RhsrsYuCMks5rPBfJgaJpZM4LYivZ .

BenScarb commented 7 years ago

Yes, probably worth taking in to account. Also \r\n. Using .splitlines() to do all three cases in one go :)

shawaj commented 7 years ago

Awesome, looks great. Thanks so much :-)

On 5 Jan 2017 7:57 am, "Ben" notifications@github.com wrote:

Yes, probably worth taking in to account. Also \r\n. Using .splitlines() to do all three cases in one go :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PiSupply/PaPiRus/pull/68#issuecomment-270584776, or mute the thread https://github.com/notifications/unsubscribe-auth/ADNCuhAs9-h01Mc3qBvXy5FQwbrpJTkpks5rPKJXgaJpZM4LYivZ .

francesco-vannini commented 7 years ago

@BenScarb is there a way we could refactor papirus-write to include this new feature but end up with only one write approach instead of two?

BenScarb commented 7 years ago

I'll have a look, I thought papirus-write was a complied file! Shouldn't be a problem to change it out, optional params for X and Y, then pass it all to the existing routines. There wouldn't be any speed updates as it would happen once and then exit.

One question, does it need to run as root? I've been using it on the nearly latest OS and it seemed to be fine without sudo'ing anything.

shawaj commented 7 years ago

The main idea behind it was really not for speed but just so that it isn't confusing.... Could have one write command, with optional X,Y and if you don't put an X,Y it just defaults to normal.

That's kind of what we were thinking

On 22 Jan 2017 9:46 pm, "Ben" notifications@github.com wrote:

I'll have a look, I thought papirus-write was a complied file! Shouldn't be a problem to change it out, optional params for X and Y, then pass it all to the existing routines. There wouldn't be any speed updates as it would happen once and then exit.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PiSupply/PaPiRus/pull/68#issuecomment-274362247, or mute the thread https://github.com/notifications/unsubscribe-auth/ADNCuv7hPqWpJeSAfKdmHy1AjMh7__Bwks5rU84jgaJpZM4LYivZ .

shawaj commented 7 years ago

@BenScarb realised I forgot to tag you in my last reply. Just wanted to check you saw it

BenScarb commented 7 years ago

No worries, I'll be taking a look tomorrow :) Assuming I can find where I tidied my Pi away to!

shawaj commented 7 years ago

:-)

On 1 Feb 2017 10:11 pm, "Ben" notifications@github.com wrote:

No worries, I'll be taking a look tomorrow :) Assuming I can find where I tidied my Pi away to!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PiSupply/PaPiRus/pull/68#issuecomment-276799540, or mute the thread https://github.com/notifications/unsubscribe-auth/ADNCuvjMuoI3lMvOzALMZHAm3CGsMsZJks5rYQMZgaJpZM4LYivZ .

BenScarb commented 7 years ago

Found the Pi! Sorted the papirus-write to accept the X and Y coords and use the appropriate code. Updated the textpos class as the strings weren't being accepted as having a line break in, so needed to be (un-)escaped.

Not sure what I've done to the ReadMe.md file, thought I'd fixed it, looked all right on http://dillinger.io/ but not do good on GitHub!

francesco-vannini commented 7 years ago

Ben I'll take a look at this next week, thanks for the effort, really appreciated and sorry it is taking so long to review this. Keep you posted.

BenScarb commented 7 years ago

No worries, I know life happens :) If anything else needs updating or de-conflicting, just drop me a message.

francesco-vannini commented 7 years ago

Hi, I have finally tested the code which works really nicely, thanks! Only one thing now could you redo the README.md changes using the current file. That should also help cleaning up that strange behaviour you saw caused by you removing the "Your python script must be running with root privileges ... " part but you left behind one ``` Also if possible could you please clean up the various commits and collapse the new in just one as we did for #55 Many thanks once again. I'll merge as soon as I get the new changes.

BenScarb commented 7 years ago

No worries, I'll see if I can get the changes done tonight. My "diffing skills" need working on me thinks, didn't see what I'd left behind! Read up on the "needing root" stuff, good call. I'll get the current ReadMe.MD updated and uploaded.

BenScarb commented 7 years ago

I have updated the README.md, I believe it's sorted but the conflict still exists. Seems I need to research how to do that! I think just taking the version from branch will do it :)

shawaj commented 7 years ago

Me and @francesco-vannini can probably fix it next week.

I think basically you just need to do a git rebase but then I'm also pretty awful at git so it's like the blind leading the blind :-)

Let's all have a go next week and see if we can fix it

On 11 Mar 2017 4:22 pm, "Ben" notifications@github.com wrote:

I have updated the README.md, I believe it's sorted but the conflict still exists. Seems I need to research how to do that! I think just taking the version from branch will do it :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PiSupply/PaPiRus/pull/68#issuecomment-285878548, or mute the thread https://github.com/notifications/unsubscribe-auth/ADNCukJcITbDrSb2w6FdQWlHawCzmvFCks5rkspdgaJpZM4LYivZ .

BenScarb commented 7 years ago

Great stuff, sorry I can't give you a fully formed branch to pull in. Something for me to work on, every days a learning day :)

shawaj commented 7 years ago

No need to be sorry! It's awesome to have people like you contributing code :-)

On 12 Mar 2017 7:30 pm, "Ben" notifications@github.com wrote:

Great stuff, sorry I can't give you a fully formed branch to pull in. Something for me to work on, every days a learning day :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PiSupply/PaPiRus/pull/68#issuecomment-285968883, or mute the thread https://github.com/notifications/unsubscribe-auth/ADNCurPeJ47KjV7gLWrOasNJLRslJL2aks5rlEfsgaJpZM4LYivZ .

BenScarb commented 7 years ago

Once this is merged in, I'll take a look at inverting the colours, or at least having control over them :) The White on Black seems like a good idea!

shawaj commented 7 years ago

Yeah definitely. Someone's just mentioned it in #80 actually

On 12 Mar 2017 7:51 pm, "Ben" notifications@github.com wrote:

Once this is merged in, I'll take a look at inverting the colours, or at least having control over them :) The White on Black seems like a good idea!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PiSupply/PaPiRus/pull/68#issuecomment-285970741, or mute the thread https://github.com/notifications/unsubscribe-auth/ADNCusUyJztmLyTYc7Pee7JFGrhgJAcKks5rlEzIgaJpZM4LYivZ .

francesco-vannini commented 7 years ago

Thanks a lot @BenScarb - all sorted and merged now :-)

Thanks so much for your contribution!

BenScarb commented 7 years ago

Woohoo, my first proper submissions and completed PR! Glad it'll be useful :)

shawaj commented 7 years ago

Yes indeed, we just copy pasted the readme as we couldn't be bothered to fix it "the proper way" :-)

On 15 Mar 2017 7:34 pm, "Ben" notifications@github.com wrote:

Woohoo, my first proper submissions and completed PR! Glad it'll be useful :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PiSupply/PaPiRus/pull/68#issuecomment-286854552, or mute the thread https://github.com/notifications/unsubscribe-auth/ADNCuh5sB4707ueD0OD7ySmTLeomU0Enks5rmD1JgaJpZM4LYivZ .