search

PiSupply / PaPiRus

Resources for PaPiRus ePaper eInk displays
https://www.pi-supply.com/product/papirus-epaper-eink-screen-hat-for-raspberry-pi/
Other
346 stars 88 forks source link

PaPiRus textpos does only a partial update? #91

Closed shawaj closed 7 years ago

shawaj commented 7 years ago

PaPiRus textpos does only a partial update, so if there's something over the screen.

@BenScarb @francesco-vannini do you think it would be better to have it with a full update, or have an option to do either a full or partial update? I like the idea of a partial update as it allows you to write text over an image but sometimes you just want text...

What do you think?

francesco-vannini commented 7 years ago

I think textpos.py should default to full update and have an option for partial Changed textpos.py to only do full updates in #94 until the option is introduced.

shawaj commented 7 years ago

Yes, agreed @francesco-vannini - the partial should be an argument. This should probably be the case with all example scripts

francesco-vannini commented 7 years ago

@BenScarb this has been dealt with right?

francesco-vannini commented 7 years ago

I think this could be closed

shawaj commented 7 years ago

Did we fix it already?

shawaj commented 7 years ago

@benscarb was this fix part of #105?

BenScarb commented 7 years ago

I do believe it was, commits on the 4th of Apr allow for partial or full updates to be done. Defaults to Full update. https://github.com/PiSupply/PaPiRus/pull/105#commits-pushed-609ddbc

francesco-vannini commented 7 years ago

Thanks @BenScarb, closing this up.