Remember to free() result of convertBytesToString.

PiSupply / RAK811-Arduino

Arduino Library for Pi Supply LoRa Node Shield

MIT License

8 stars 7 forks source link

Remember to free() result of convertBytesToString. #10

Closed rbricheno closed 4 years ago

rbricheno commented 4 years ago

Probably closes #6 (not tested yet, my arduino is bust and I'm on holiday, please let me know!).

ryanteck commented 4 years ago

Thanks @rbricheno !

I think it looks like this should fix issue #6 , Tomorrow I'll test my unit without this fix first, then test it with it added then merge it in.

rbricheno commented 4 years ago

Awesome, if not I'll test as soon as I get my hands on another Arduino.

Thinking properly about this, there's still possible an open problem as part of #6 with the "I2C TOFL-Sensor" and this won't affect that, so we might need to keep #6 open for that. It should be easier to troubleshoot once rk_sendBytes is fixed though!

ryanteck commented 4 years ago

Thanks @rbricheno seems to have fixed it!

I'll do some extended testing but either way it's improved it.